-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): acknowledge animation when Flex receives a new protocol #13474
feat(app): acknowledge animation when Flex receives a new protocol #13474
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13474 +/- ##
=======================================================
+ Coverage 71.23% 71.36% +0.13%
=======================================================
Files 1547 2433 +886
Lines 50312 68070 +17758
Branches 3435 7919 +4484
=======================================================
+ Hits 35838 48581 +12743
- Misses 13945 17630 +3685
- Partials 529 1859 +1330
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! only complaint is the Incidental
naming cuz its kinda vague, but honestly i dont have anything better and we can change the name later if we want. thx frank!
Co-authored-by: Jethary Rader <[email protected]>
…13474) * Add schemaV7 definition for StatusBarAnimation control * When ODD detects a new protocol, run status bar Confirm animation * Update app/src/App/hooks.ts typo Co-authored-by: Jethary Rader <[email protected]> --------- Co-authored-by: Jethary Rader <[email protected]>
…13474) * Add schemaV7 definition for StatusBarAnimation control * When ODD detects a new protocol, run status bar Confirm animation * Update app/src/App/hooks.ts typo Co-authored-by: Jethary Rader <[email protected]> --------- Co-authored-by: Jethary Rader <[email protected]>
Overview
The design spec for the status bar calls for the Confirmation animation to play when a new protocol is uploaded. We already have 1) a stateless protocol engine command to run that animation, and 2) a hook in the ODD app to detect when a new protocol is uploaded. This PR just glues those two things together.
Test Plan
Pushed this to Flexy and uploaded a protocol.
Changelog
confirm
animation if a new protocol was uploadedReview requests
Risk assessment
Pretty low, not core behavior