Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix module calibration overflowmenu bug #13469

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 6, 2023

Overview

Use formattedPipetteOffsetCalibrations as well as pipette calibration table since the previous implementation always gets empty.
Check pipettes are attached and calibrated -> allow users to calibrate modules

closes RQA-1485

Test Plan

Changelog

Review requests

Risk assessment

low

koji and others added 2 commits September 5, 2023 20:27
use formattedPipetteOffsetCalibrations data instead of calling react-api-client

fix RQA-1485
@koji koji changed the base branch from edge to chore_release-7.0.0 September 6, 2023 04:20
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #13469 (a75e01e) into chore_release-7.0.0 (43e8e92) will increase coverage by 0.03%.
Report is 13 commits behind head on chore_release-7.0.0.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13469      +/-   ##
=======================================================
+ Coverage                71.38%   71.41%   +0.03%     
=======================================================
  Files                     2433     2433              
  Lines                    68054    68156     +102     
  Branches                  7924     7928       +4     
=======================================================
+ Hits                     48581    48677      +96     
- Misses                   17618    17620       +2     
- Partials                  1855     1859       +4     
Flag Coverage Δ
app 69.25% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tion/CalibrationDetails/ModuleCalibrationItems.tsx 100.00% <ø> (ø)
...ingsCalibration/RobotSettingsModuleCalibration.tsx 100.00% <ø> (ø)
...librationDetails/ModuleCalibrationOverflowMenu.tsx 90.47% <100.00%> (-1.53%) ⬇️
...p/src/organisms/RobotSettingsCalibration/index.tsx 51.76% <100.00%> (+0.57%) ⬆️

... and 3 files with indirect coverage changes

@koji koji changed the title Fix module calibration overflow menu bug fix(app): fix module calibration overflowmenu bug Sep 6, 2023
@koji koji requested a review from a team September 6, 2023 13:50
@koji koji marked this pull request as ready for review September 6, 2023 13:50
@koji koji requested a review from a team as a code owner September 6, 2023 13:50
@koji koji requested review from TamarZanzouri and removed request for a team and TamarZanzouri September 6, 2023 13:50
@mjhuff
Copy link
Contributor

mjhuff commented Sep 6, 2023

Tested code and works as expected, but I wonder if we should show some sort of feedback to let people know they need to calibrate pipettes first? Seems hard to tell it's necessary on this page. IDK, this is probably a design question.

Screen.Recording.2023-09-06.at.11.46.26.AM.mov

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this in person - lgtm 🚀

@koji koji merged commit fdf6e22 into chore_release-7.0.0 Sep 7, 2023
jerader pushed a commit that referenced this pull request Sep 12, 2023
* fix(app): fix module calibration overflowmenu bug and disabled each menu button instead of overflowmenu itself
TamarZanzouri pushed a commit that referenced this pull request Sep 13, 2023
* fix(app): fix module calibration overflowmenu bug and disabled each menu button instead of overflowmenu itself
@koji koji deleted the fix_module-calibration-overflow-menu-bug branch November 29, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants