-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): fix module calibration overflowmenu bug #13469
fix(app): fix module calibration overflowmenu bug #13469
Conversation
use formattedPipetteOffsetCalibrations data instead of calling react-api-client fix RQA-1485
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13469 +/- ##
=======================================================
+ Coverage 71.38% 71.41% +0.03%
=======================================================
Files 2433 2433
Lines 68054 68156 +102
Branches 7924 7928 +4
=======================================================
+ Hits 48581 48677 +96
- Misses 17618 17620 +2
- Partials 1855 1859 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested code and works as expected, but I wonder if we should show some sort of feedback to let people know they need to calibrate pipettes first? Seems hard to tell it's necessary on this page. IDK, this is probably a design question. Screen.Recording.2023-09-06.at.11.46.26.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this in person - lgtm 🚀
* fix(app): fix module calibration overflowmenu bug and disabled each menu button instead of overflowmenu itself
* fix(app): fix module calibration overflowmenu bug and disabled each menu button instead of overflowmenu itself
Overview
Use
formattedPipetteOffsetCalibrations
as well as pipette calibration table since the previous implementation always gets empty.Check pipettes are attached and calibrated -> allow users to calibrate modules
closes RQA-1485
Test Plan
Changelog
Review requests
Risk assessment
low