feat(app): wire up module calibration to backend #13449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
commented
Sep 1, 2023
Comment on lines
-172
to
-173
| return errorMessage != null ? ( | ||
| <SimpleWizardBody |
There was a problem hiding this comment.
moved rendering the error to the orchestration component, rather than having each sub component have to worry about rendering error content
Comment on lines
+67
to
+69
| const [createdAdapterId, setCreatedAdapterId] = React.useState<string | null>( | ||
| null | ||
| ) |
There was a problem hiding this comment.
added this because when starting module cal, we need to provide the PE command the loaded adapter id
shlokamin
requested review from
TamarZanzouri
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13449 +/- ##
=======================================================
- Coverage 71.41% 63.34% -8.07%
=======================================================
Files 2432 1710 -722
Lines 67907 32551 -35356
Branches 7884 7925 +41
=======================================================
- Hits 48495 20621 -27874
+ Misses 17567 10080 -7487
- Partials 1845 1850 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shlokamin
commented
Sep 1, 2023
Comment on lines
+1230
to
1237
| const { moduleId, model, location } = command.params | ||
| if (moduleId == null) { | ||
| console.error( | ||
| `expected module ${model} in location ${location.slotName} to have an id, but id does not` | ||
| ) | ||
| return acc | ||
| } | ||
| return { |
There was a problem hiding this comment.
added this change to PD cuz i updated the type of LoadModuleCreateCommand to have the module id be optional
shlokamin
commented
Sep 1, 2023
| return | ||
| } | ||
|
|
||
| const calibrationAdapterId = uuidv4() |
There was a problem hiding this comment.
generating a uuid for the calibration adapter and setting it to react state below so we can use this id when we emit a start module cal command
…ons into app-wire-up-module-cal]
mjhuff
pushed a commit
that referenced
this pull request
Sep 5, 2023
RAUT-655 Co-authored-by: Brian Cooper <[email protected]> Co-authored-by: smb2268 <[email protected]>
TamarZanzouri
pushed a commit
that referenced
this pull request
Sep 13, 2023
RAUT-655 Co-authored-by: Brian Cooper <[email protected]> Co-authored-by: smb2268 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR wires up module cal to protocol engine.
closes RAUT-655
(also small copy fix) closes RQA-935
Changelog
Risk assessment
Low