-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api, shared-data): add location-based gripper offsets to final labware movement offsets #13186
feat(api, shared-data): add location-based gripper offsets to final labware movement offsets #13186
Conversation
Codecov Report
@@ Coverage Diff @@
## internal-release_0.14.0 #13186 +/- ##
===========================================================
+ Coverage 72.51% 72.53% +0.01%
===========================================================
Files 2392 2392
Lines 66004 66032 +28
Branches 7327 7327
===========================================================
+ Hits 47865 47895 +30
+ Misses 16392 16391 -1
+ Partials 1747 1746 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shared-data/deck/schemas/3.json
Outdated
"required": [ | ||
"pickUpOffset", | ||
"dropOffset" | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add default as required
}, | ||
total=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this assigned TypedDict to class-based and see if anything breaks. If not, switch to that and split it into required vs optional typed dicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
punting this to later
2e19aa3
to
71156f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @andySigler @ChrisYarka for verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @andySigler @ChrisYarka for verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @andySigler @ChrisYarka for verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @andySigler @ChrisYarka for verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my results from testing the PR as-is, and from testing it with adjusted offsets that @andySigler gave me in this spreadsheet.
Pickup/drop location | Sanniti's original offsets | Andy's offsets |
---|---|---|
armadillo_96_wellplate_200ul_pcr_full_skirt on bare deck slot |
✅ | ✅ |
armadillo_96_wellplate_200ul_pcr_full_skirt on thermocyclerModuleV2 |
❌ In the jaw-open immediately after the drop, the jaws collide with the TC. Pickup not attempted. | ❌ Same. |
armadillo_96_wellplate_200ul_pcr_full_skirt on temperatureModuleV2 |
❌ During both pickup and drop, it collides with the ~2mm lip around the edge of the module's slot. | ❌ Same. |
armadillo_96_wellplate_200ul_pcr_full_skirt on magneticBlockV1 |
🤷♂️ It seems to think the labware sits ~2 mm higher than it actually does. | 🤷♂️ Same. |
corning_384_wellplate_112ul_flat on opentrons_universal_flat_adapter on heaterShakerModuleV1 |
✅ | ✅ |
armadillo_96_wellplate_200ul_pcr_full_skirt on opentrons_96_pcr_adapter on heaterShakerModuleV1 |
✅ | ✅ |
Recap from in-person work with @sanni-t, @andySigler, and @jbleon95:
Thinking continues on where we should take this work in the medium/long-term.
|
Closes RLAB-295
Overview
Takes the location-based offsets we have been using in protocols and puts them in definitions so that they are included by default while calculating total gripper offsets.
Test Plan
Changelog
gripperOffsets
to deck, labware & module schemasReview requests
Risk assessment
Medium. The offset calculations are unit tested & will be robot tested well so that's not a risk. But we should make sure the actual offsets being added are correct.