feat(api): remove use of LPC offsets during labware movement #13144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes RLAB-237
From hardware testing it has been found that adding LPC offsets during labware movement with gripper makes labware pick ups and drops unreliable. But having the pickUp & drop offsets is useful for fine tuning the default positions of labware pickUp & drop. So this PR removes the use of just LPC offsets from API and engine's labware movement commands.
Helps reduce change diff for RLAB-295.
Test Plan
Just unit tests and linting should suffice since this is removing a functionality that neither science/beta testers not hardware testing is using. Still, a quick test of labware movement on the flex would be helpful in making sure everything still works before making the larger changes of RLAB-295.
Changelog
use_pick_up_location_lpc_offset
anduse_drop_location_lpc_offset
fromprotocol_context.move_labware
argsusePickUpLocationLpcOffset
anduseDropLocationLpcOffset
frommoveLabware
engine commandReview requests
Risk assessment
Low. Just a risk about 'whether the lpc offsets could ever be useful?'. But we can always put them back in if that happens.