Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): add definition for nest 1 well reservoir with 290ml capacity #13122

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Jul 18, 2023

Overview

Add new definition to labware data for Nest 1 well reservoir 290ml.

Closes RAUT-558

Screen Shot 2023-07-18 at 2 13 13 PM

Risk assessment

low

@b-cooper b-cooper requested a review from shlokamin July 18, 2023 18:13
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #13122 (66de912) into edge (4186bb2) will decrease coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13122      +/-   ##
==========================================
- Coverage   73.14%   72.53%   -0.62%     
==========================================
  Files        2337     2388      +51     
  Lines       64487    65873    +1386     
  Branches     7111     7304     +193     
==========================================
+ Hits        47172    47782     +610     
- Misses      15590    16345     +755     
- Partials     1725     1746      +21     
Flag Coverage Δ
app 71.21% <ø> (-2.68%) ⬇️
labware-library 49.51% <ø> (ø)
protocol-designer 47.28% <ø> (ø)
shared-data 78.29% <ø> (ø)
step-generation 87.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets merge so science can test in the next internal release

@b-cooper b-cooper merged commit 15fcb0e into edge Jul 19, 2023
@b-cooper b-cooper deleted the shared-data_add-nest-tall-reservoir branch July 19, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants