feat(protocol-designer): fixed trash id in correct slot depending on robot #13098
+249
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #13098 +/- ##
==========================================
- Coverage 72.57% 72.40% -0.17%
==========================================
Files 2382 1559 -823
Lines 65896 51734 -14162
Branches 7286 3230 -4056
==========================================
- Hits 47821 37458 -10363
+ Misses 16338 13761 -2577
+ Partials 1737 515 -1222
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
reviewed
Jul 17, 2023
| labwareLocationUpdate: { | ||
| [FIXED_TRASH_ID]: { | ||
| slotName: | ||
| values.fields.robotType === FLEX_ROBOT_TYPE ? 'A3' : '12', |
There was a problem hiding this comment.
maybe define constants for ot2 trash and flex trash?
koji
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-539
Overview
co-authored with @b-cooper
Flex protocols should have correct trash slot
Test Plan
sandbox: https://sandbox.designer.opentrons.com/pd_init-fixed-trash-location-for-flex
create an OT-2 protocol, the JSON file should say 12 for trash slot name. For Flex protocols, it should say A3 for trash slot name
Changelog
changeSavedStepFormto also add the trash labware location and remove it from the hard coded constCreateFileWizardand test out the trash slot locationsReview requests
see test plan
Risk assessment
low