Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware-testing): 96ch photometric confirm volume at beginning #13041

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove typos
andySigler committed Jul 5, 2023
commit 4824ce6965d1e86eec02fcb2b4d1445a973eae25
Original file line number Diff line number Diff line change
@@ -297,11 +297,10 @@ def _record_measurement_and_store(m_type: MeasurementType) -> EnvironmentData:
liquid_tracker.set_start_volume(source, required_ul)
reservoir_ul = liquid_tracker.get_volume(source)
print(
f"software thinks there is {reservoir_ul} mL "
f"of liquid in the reservoir (required = {required_ul} ml)"
f"software thinks there is {round(reservoir_ul / 1000, 1)} mL "
f"of liquid in the reservoir (required = {round(required_ul / 1000, 1)} ml)"
)
if required_ul <= reservoir_ul < _MAX_VOLUME_UL:
print("good")
break
elif required_ul > _MAX_VOLUME_UL:
raise NotImplementedError(
@@ -323,7 +322,9 @@ def _record_measurement_and_store(m_type: MeasurementType) -> EnvironmentData:
)
pipette.move_to(location=source.top().move(channel_offset))
else:
print("huh?")
raise RuntimeError(
f"bad volume in reservoir: {round(reservoir_ul / 1000, 1)} ml"
)
# RUN ASPIRATE
aspirate_with_liquid_class(
ctx,