Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware-testing): Actually use increment protocols so correct labware is loaded #13003

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

andySigler
Copy link
Contributor

Overview

We were accidentally not loading in the "increment" labware types/locations when executing, so the vial was being assumed instead of the trough and liquid-levels were wrong.

Protocols file are currently used to define labware types and locations per each test scenario. These are then used to run LPC before a test is executed.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from adcooll June 28, 2023 13:50
@andySigler andySigler requested a review from a team as a code owner June 28, 2023 13:50
@andySigler andySigler requested a review from ryanthecoder June 28, 2023 13:51
Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andySigler andySigler merged commit e12ff88 into edge Jun 28, 2023
@andySigler andySigler deleted the 8ch-pipette-increment-jun-28 branch June 28, 2023 14:45
andySigler added a commit that referenced this pull request Jul 12, 2023
andySigler added a commit that referenced this pull request Jul 12, 2023
andySigler added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants