Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): exclude module calibration adapters from being rendered. #12971

Merged
merged 3 commits into from
Jun 28, 2023
Merged

fix(shared-data): exclude module calibration adapters from being rendered. #12971

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
022cb5e
fix(shared-data): exclude module calibration adapters from being rend…
vegano1 Jun 23, 2023
0e716c3
move down and add comment for clarity
vegano1 Jun 23, 2023
6d7d171
Merge branch 'edge' into RQA-811_hide_calibration_adapters
vegano1 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions shared-data/js/getLabware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ export const LABWAREV2_DO_NOT_LIST = [
'eppendorf_96_tiprack_10ul_eptips',
'opentrons_calibrationblock_short_side_left',
'opentrons_calibrationblock_short_side_right',
'opentrons_calibration_adapter_heatershaker_module',
'opentrons_calibration_adapter_magnetic_module',
'opentrons_calibration_adapter_temperature_module',
'opentrons_calibration_adapter_thermocycler_module',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we move these below the TODO(lc 8-24-2022) comment below? Right now, the comment above makes it look like these are for "back-compat with legacy v1 defs."

Also, do we need these in PD_DO_NOT_LIST too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do,
and I'm not sure,
@b-cooper do we also want to add to PD_DO_NOT_LIST ?

// TODO(lc 8-24-2022) We are temporarily filtering
// out ot-3 labware definitions right now. We should
// have a way to filter these in the future to display
Expand Down