Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): remove text size from ODD settings #12842

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Conversation

shlokamin
Copy link
Member

Overview

This PR removes text size from the ODD's robot settings and fixes a failing test I broke in this PR: #12840

@shlokamin shlokamin requested a review from a team as a code owner June 2, 2023 16:51
@shlokamin shlokamin requested review from b-cooper and removed request for a team June 2, 2023 16:51
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #12842 (21b8899) into edge (9d4de66) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12842      +/-   ##
==========================================
+ Coverage   73.13%   73.34%   +0.21%     
==========================================
  Files        1490     2284     +794     
  Lines       48990    62730   +13740     
  Branches     2913     6829    +3916     
==========================================
+ Hits        35827    46011   +10184     
- Misses      12707    15087    +2380     
- Partials      456     1632    +1176     
Flag Coverage Δ
app 71.40% <ø> (+27.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...viceDisplay/RobotSettingsDashboard/DeviceReset.tsx 83.87% <ø> (ø)
...y/RobotSettingsDashboard/NetworkSettings/index.tsx 79.48% <ø> (ø)
...play/RobotSettingsDashboard/RobotSystemVersion.tsx 91.66% <ø> (ø)
...isplay/RobotSettingsDashboard/TouchScreenSleep.tsx 90.00% <ø> (ø)
...y/RobotSettingsDashboard/TouchscreenBrightness.tsx 100.00% <ø> (ø)
...ceDisplay/RobotSettingsDashboard/UpdateChannel.tsx 82.35% <ø> (ø)
...s/OnDeviceDisplay/RobotSettingsDashboard/index.tsx 73.33% <ø> (ø)

... and 787 files with indirect coverage changes

Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@shlokamin shlokamin merged commit 030b9a0 into edge Jun 2, 2023
@shlokamin shlokamin deleted the app_dqa-settings branch June 2, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants