Revert "fix(api): disable motors during the pipette attach and detach position" #12784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## internal-release_0.9.0 #12784 +/- ##
=======================================================
Coverage 73.36% 73.36%
=======================================================
Files 2295 2295
Lines 63076 63076
Branches 6858 6858
=======================================================
Hits 46273 46273
Misses 15180 15180
Partials 1623 1623
Flags with carried forward coverage won't be shown. Click here to find out more. |
Laura-Danielle
deleted the
revert-12772-move_to_maintenance_disable_motors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotta figure out what to do about safely disabling the ZA motors. Currently the firmware (correctly) sets the motor status as not OK as soon as the motors get disabled so doing this causes the hardware controller to think that the disabled axes need to be homed :(.
Reverts #12772