fix(app, react-api-client): fix tests after weird merges #12710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
requested review from
b-cooper,
koji and
a team
and removed request for
a team
shlokamin
force-pushed
the
fix_odd-protocol-setup-test
branch
from
187539f to
4488891
Compare
Codecov Report
@@ Coverage Diff @@
## internal-release_0.8.0 #12710 +/- ##
==========================================================
- Coverage 73.04% 73.03% -0.01%
==========================================================
Files 1482 1483 +1
Lines 48172 48184 +12
Branches 3021 3022 +1
==========================================================
+ Hits 35188 35192 +4
- Misses 12520 12528 +8
Partials 464 464
Flags with carried forward coverage won't be shown. Click here to find out more. |
b-cooper
pushed a commit
that referenced
this pull request
May 16, 2023
b-cooper
added a commit
that referenced
this pull request
May 16, 2023
Co-authored-by: Shlok Amin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At the end of the day yesterday we merged in a flurry of PRs that resulted in some frontend test failures. This PR should fix those failures and make edge green again.
Review Requests
Make sure all frontend tests pass on this PR
Risk assessment
Low