-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(odd): Add Run Completion and Run Summary screen #12597
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12597 +/- ##
==========================================
- Coverage 73.57% 73.54% -0.04%
==========================================
Files 2269 2270 +1
Lines 62371 62412 +41
Branches 6605 6619 +14
==========================================
+ Hits 45889 45898 +9
- Misses 14906 14937 +31
- Partials 1576 1577 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
app/src/organisms/InstrumentMountItem/ProtocolInstrumentMountItem.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/InstrumentMountItem/__tests__/ProtocolInstrumentMountItem.test.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/InstrumentMountItem/__tests__/ProtocolInstrumentMountItem.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be in a follow up PR, but we also need to dismiss the run when pressing each modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 thanks @koji this is great!
Overview
Add Run Completion and Run Summary screen
This PR has some comment-out lines because I took over this branch from @b-cooper so I just avoid breaking anything that is not directly related to RunCompletion and RunSummary screen
info icon for View error details doesn't fit the design because I have a PR that is including the new info icon.
this part will be updated once the PR is merged into
edge
The test will be added later. (I will work on that.)
close RCORE-744 RCORE-745
[design]
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/Release%3A-Opentrons-Flex-Touchscreen-Designs?node-id=5201-95033&t=vNmTK9KKiPQI627z-0
Test Plan
Changelog
Review requests
Risk assessment
low