Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(odd): Add Run Completion and Run Summary screen #12597

Merged
merged 19 commits into from
May 1, 2023
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 28, 2023

Overview

Add Run Completion and Run Summary screen
This PR has some comment-out lines because I took over this branch from @b-cooper so I just avoid breaking anything that is not directly related to RunCompletion and RunSummary screen

info icon for View error details doesn't fit the design because I have a PR that is including the new info icon.
this part will be updated once the PR is merged into edge

The test will be added later. (I will work on that.)

close RCORE-744 RCORE-745

[design]
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/Release%3A-Opentrons-Flex-Touchscreen-Designs?node-id=5201-95033&t=vNmTK9KKiPQI627z-0

Test Plan

  • send a protocol to OT-3/Dev kit
  • run a protocol

Changelog

  • add RunSummary component
  • update OnDeviceDisplayApp test
  • modify LarageButton
  • update RunningProtocol component to display RunCompletion and RunSummary screen

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review April 28, 2023 21:27
@koji koji requested a review from a team as a code owner April 28, 2023 21:27
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #12597 (4bf9973) into edge (a41d3a2) will decrease coverage by 0.04%.
The diff coverage is 21.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12597      +/-   ##
==========================================
- Coverage   73.57%   73.54%   -0.04%     
==========================================
  Files        2269     2270       +1     
  Lines       62371    62412      +41     
  Branches     6605     6619      +14     
==========================================
+ Hits        45889    45898       +9     
- Misses      14906    14937      +31     
- Partials     1576     1577       +1     
Flag Coverage Δ
app 72.00% <21.95%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/App/OnDeviceDisplayApp.tsx 66.66% <ø> (ø)
.../src/atoms/buttons/OnDeviceDisplay/LargeButton.tsx 100.00% <ø> (ø)
app/src/organisms/Devices/utils.ts 50.00% <0.00%> (-3.34%) ⬇️
.../RunningProtocol/CurrentRunningProtocolCommand.tsx 70.58% <ø> (ø)
...p/src/organisms/ProtocolSetupInstruments/index.tsx 38.09% <ø> (ø)
.../pages/OnDeviceDisplay/ProtocolDashboard/index.tsx 14.06% <ø> (ø)
app/src/pages/OnDeviceDisplay/ProtocolSetup.tsx 69.33% <ø> (ø)
app/src/pages/OnDeviceDisplay/RunSummary.tsx 19.44% <19.44%> (ø)
app/src/pages/OnDeviceDisplay/RunningProtocol.tsx 62.50% <50.00%> (-1.39%) ⬇️

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be in a follow up PR, but we also need to dismiss the run when pressing each modal

@koji koji requested a review from shlokamin May 1, 2023 16:19
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks @koji this is great!

@sfoster1 sfoster1 merged commit 521e688 into edge May 1, 2023
@sfoster1 sfoster1 deleted the odd_successful-run branch May 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants