Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix cal check step numbers and return tip, labware offset data help copy #12423

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Apr 3, 2023

Overview

Fix logic that calculates the step number within the newly redesigned calibration health check flow
based on how many pipettes are being checked. Modernize contents of return tip step in cal check.
fix help copy in learn more about labware position check offsets. Disable "recalibrate" link in the Deck Calibration item if there are no pipettes attached.

Screen Shot 2023-04-03 at 5 50 23 PM

Screen Shot 2023-04-03 at 6 00 11 PM

Screen Shot 2023-04-03 at 6 02 35 PM

Screen Shot 2023-04-03 at 6 02 40 PM

Screen Shot 2023-04-03 at 6 02 56 PM

Closes RQA-611, Closes RQA-609, Closes RAUT-393, Closes RQA-613

Risk assessment

low

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #12423 (fdcfdfb) into release_6.3.0 (4fca778) will increase coverage by 0.00%.
The diff coverage is 73.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release_6.3.0   #12423   +/-   ##
==============================================
  Coverage          65.76%   65.76%           
==============================================
  Files               1736     1735    -1     
  Lines              35763    35753   -10     
  Branches            6225     6223    -2     
==============================================
- Hits               23520    23514    -6     
+ Misses             10810    10805    -5     
- Partials            1433     1434    +1     
Flag Coverage Δ
app 72.51% <73.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/organisms/ApplyHistoricOffsets/index.tsx 95.65% <ø> (ø)
app/src/organisms/CheckCalibration/index.tsx 64.86% <50.00%> (-0.93%) ⬇️
app/src/organisms/CalibrationTaskList/index.tsx 88.57% <66.66%> (-4.77%) ⬇️
app/src/organisms/CalibrationPanels/SaveZPoint.tsx 100.00% <100.00%> (ø)
app/src/organisms/CheckCalibration/ReturnTip.tsx 100.00% <100.00%> (ø)

…ata help copy

Fix logic that calculates the step number within the newly redesigned calibration health check flow
based on how many pipettes are being checked. Modernize contents of return tip step in cal check.
fix help copy in learn more about labware position check offsets.

Closes RQA-611, Closes RQA-609, Closes RAUT-393, Closes RQA-613
@b-cooper b-cooper force-pushed the app_fix-return-tip-health-check branch from 7d3d845 to 6b94f2e Compare April 3, 2023 22:03
@b-cooper b-cooper marked this pull request as ready for review April 3, 2023 22:06
@b-cooper b-cooper requested a review from a team as a code owner April 3, 2023 22:06
@b-cooper b-cooper requested review from shlokamin, ecormany, emilywools and nusrat813 and removed request for a team April 3, 2023 22:06
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on dev server with Brian and works as expected

@b-cooper b-cooper merged commit d1db655 into release_6.3.0 Apr 4, 2023
@b-cooper b-cooper deleted the app_fix-return-tip-health-check branch April 4, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants