Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing, api): add module calibration HTTP script and supporting changes #12415

Merged
merged 5 commits into from
Apr 10, 2023

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Apr 3, 2023

Overview

We need to test module calibration to tune in hardware specs and iron out any issues in the logic, this PR adds a script to let us run module calibration via HTTP from a desktop or robot.

Closes RCORE-665

Test Plan

  • Run module calibration script on Temperature module
  • Run module calibration script on HeaterShaker module
  • Run module calibration script on Magnetic module
  • Run module calibration using single channel pipette

Changelog

  • add calibrate_module.py script to run module calibration via HTTP
  • add OT3MountType to allow the use of the gripper as an instrument
  • module adapter definition changes

Review requests

  • Is there something else we would like the script to do
  • Is anything missing?

Risk assessment

Low, flex work

@vegano1 vegano1 requested review from sfoster1 and andySigler April 3, 2023 14:31
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #12415 (263a001) into edge (df7ebe7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12415      +/-   ##
==========================================
- Coverage   73.81%   73.79%   -0.02%     
==========================================
  Files        2228     2227       -1     
  Lines       61587    61530      -57     
  Branches     6381     6381              
==========================================
- Hits        45461    45409      -52     
+ Misses      14637    14632       -5     
  Partials     1489     1489              
Flag Coverage Δ
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/hardware_control/types.py 96.48% <ø> (-0.02%) ⬇️
api/src/opentrons/types.py 86.86% <ø> (ø)

... and 3 files with indirect coverage changes

vegano1 added 2 commits April 7, 2023 09:27
fix issue where we are applying double Z_PREP_OFFSET by just subtracting Z_PREP_OFFSET from the nominal positition
fix heater_shaker calibration adapter definitions
@vegano1 vegano1 marked this pull request as ready for review April 7, 2023 14:07
@vegano1 vegano1 requested a review from a team as a code owner April 7, 2023 14:07
@vegano1 vegano1 requested a review from a team as a code owner April 7, 2023 15:11
@vegano1 vegano1 changed the title feat(hardware-testing): add module calibration HTTP script and supporting changes feat(hardware-testing, api): add module calibration HTTP script and supporting changes Apr 7, 2023
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I really like this approach and hope we'll be able to do it for more stuff we're testing.

@vegano1 vegano1 merged commit eb62844 into edge Apr 10, 2023
@vegano1 vegano1 deleted the RCORE-665_add_module_calibration_script branch April 10, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants