Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(components): rebuild storybook components when app stories are added/modifed #12321

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

shlokamin
Copy link
Member

Overview

When trying to look at ODD components in storybook I realized that we're not rebuilding our storybook components when we add app stories. This PR will trigger our storybook components to get rebuilt whenever we make changes to/add new app stories.

Risk assessment

Low

@shlokamin shlokamin requested a review from a team as a code owner March 20, 2023 18:49
@shlokamin shlokamin requested review from b-cooper, jerader and koji March 20, 2023 18:49
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #12321 (cbb6b72) into edge (dacc8cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12321   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files        1485     1485           
  Lines       48850    48850           
  Branches     2984     2984           
=======================================
  Hits        35869    35869           
  Misses      12527    12527           
  Partials      454      454           
Flag Coverage Δ
components 66.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@shlokamin shlokamin merged commit eca2765 into edge Mar 20, 2023
@shlokamin shlokamin deleted the ci_rebiuld-components-when-app-stories-added branch March 20, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants