feat(odd): Large Button #12317
Merged
feat(odd): Large Button #12317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
brenthagen,
ewagoner,
koji and
a team
and removed request for
a team and
brenthagen
ewagoner
approved these changes
Mar 20, 2023
Codecov Report
@@ Coverage Diff @@
## edge #12317 +/- ##
==========================================
- Coverage 73.73% 73.42% -0.31%
==========================================
Files 2215 1485 -730
Lines 61086 48850 -12236
Branches 6299 2984 -3315
==========================================
- Hits 45041 35869 -9172
+ Misses 14589 12527 -2062
+ Partials 1456 454 -1002
Flags with carried forward coverage won't be shown. Click here to find out more. |
koji
reviewed
Mar 20, 2023
koji
reviewed
Mar 20, 2023
koji
reviewed
Mar 20, 2023
| onClick: () => void | ||
| buttonType: LargeButtonTypes | ||
| buttonText: React.ReactNode | ||
| disabled?: boolean |
There was a problem hiding this comment.
In the Context section, this large button component uses different icons for each button.
I think we need to pass IconName as a props.
Suggested change
| disabled?: boolean | |
| disabled?: boolean | |
| iconName: IconName |
There was a problem hiding this comment.
oops good catch! I will add that, thank you!
koji
reviewed
Mar 20, 2023
koji
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-351
Overview
Creates component, story and test for Large Button in ODD
Test Plan
examine the 3 types of buttons + the disabled state on storybook, should match figma
Changelog
LargeButtoncomponent, test and storybookReview requests
Risk assessment
low