Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing): grav script on ot3 #12302

Merged
merged 114 commits into from
Mar 17, 2023
Merged
Changes from 1 commit
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
e163f3e
moves gravimetric functionality into its own subfolder
andySigler Feb 9, 2023
10e4b09
move all ot2 functionality into gravimetric project
andySigler Feb 9, 2023
68929fe
wip
andySigler Feb 9, 2023
663ca5e
change tipracks to ot3 versions
andySigler Feb 10, 2023
16885de
can simulate on OT3
andySigler Feb 10, 2023
07c7bac
runs on ot3 without error
andySigler Feb 13, 2023
5ce3ed7
removes ProtocolContext from scale implementation
andySigler Feb 14, 2023
c48e0f3
push-plot-webpage-ot3 works
andySigler Feb 14, 2023
ff4647e
wip
andySigler Feb 14, 2023
f22e92d
DELETE THIS COMMIT
andySigler Feb 14, 2023
652a841
adds DVT pipettes to shared data
andySigler Feb 14, 2023
3898d90
ot3simulator small to change to allow simulation
andySigler Feb 17, 2023
4e710b2
local simulation working
andySigler Feb 17, 2023
598cd1e
use passed loop from ThreadManager when build OT3APIg
andySigler Feb 17, 2023
a07dfa8
use correct filepath for OT3 data files
andySigler Feb 17, 2023
df63cde
move execute to single file
andySigler Feb 17, 2023
3d1356d
placeholder for liquid-class defaults for OT3
andySigler Feb 17, 2023
13bcf9f
only read from scale when needed
andySigler Feb 21, 2023
9000b7f
remove pipette-timestamps
andySigler Feb 21, 2023
c387e16
merge in edge
andySigler Feb 24, 2023
86f8c08
integrates with scale; adds more volumes
andySigler Feb 24, 2023
558fc0f
wip
andySigler Feb 24, 2023
aa38634
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Feb 28, 2023
36174dc
remove hack from before revisioning update
andySigler Feb 28, 2023
4b8d5db
remove unnecessary v3.4 pipettes from shared-data
andySigler Feb 28, 2023
eb804da
fix merge conflicts
andySigler Mar 1, 2023
8b8361a
redo default liquid class settings for OT3 qc volumes
andySigler Mar 1, 2023
3cdffd2
deletes a lot of stuff
andySigler Mar 1, 2023
d9f3232
adds comments on reduced leading-air-gaps
andySigler Mar 1, 2023
c1cb774
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 2, 2023
e76ae4a
interpolate between liquid classes; move labware-def to static python…
andySigler Mar 2, 2023
3a3d735
increments test with cleared pipette ul-per-mm
andySigler Mar 2, 2023
26b706f
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 3, 2023
5e087a6
get labware-offsets; low_volume flag in config to filter <2uL
andySigler Mar 3, 2023
1df859f
linting
andySigler Mar 3, 2023
6ddd895
adds is_simulator to scale; reduce 50ul leading air-gaps to avoid SW bug
andySigler Mar 3, 2023
d13f398
adds blank measurements to find evaporation rate
andySigler Mar 3, 2023
9486901
add mix before aspirate
andySigler Mar 3, 2023
cdefdc8
remove aspirate after blow-out
andySigler Mar 3, 2023
c3f6ef2
change wording evaporation to blank
andySigler Mar 3, 2023
c2f1d3e
adds blowout with microliters to HW api
andySigler Mar 3, 2023
ae3dc1c
use HW api to run blow-out with microliters within grav script
andySigler Mar 3, 2023
948edc0
reorganizes pipetting sequence code; adds verbose comments
andySigler Mar 5, 2023
13b9289
wip: adding test report
andySigler Mar 6, 2023
bd77a01
wip: test-report is generated and format seems correct
andySigler Mar 6, 2023
ed1fec7
wip: most data stored, just need to calculate volumes
andySigler Mar 6, 2023
8d50021
wip: more cleaning up; store trial volumes
andySigler Mar 7, 2023
0a081eb
entire test report is filled out
andySigler Mar 7, 2023
610da18
calculate volumes using grams and environment data
andySigler Mar 7, 2023
404645f
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 7, 2023
725f8a3
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 8, 2023
0960a84
adds more args; adds fake protocol for calibrating tipracks
andySigler Mar 8, 2023
f90191b
merge in edge
andySigler Mar 8, 2023
a4bc98d
updates vial labware def
andySigler Mar 8, 2023
eb2529e
don't fail out if the rear-panel isn't found since EVT bots don't hav…
ryanthecoder Mar 8, 2023
2fb917d
put usb connected rear-panel behind a feature flag
ryanthecoder Mar 8, 2023
7315f5d
update robot server tests
ryanthecoder Mar 8, 2023
c34fdbc
few fixups from rebase
ryanthecoder Mar 8, 2023
52e127a
Merge branch 'evt_rear_panel_fix' into feat-hardware-testing-grav-scr…
andySigler Mar 9, 2023
1c9b29d
linting error from pipette qc script
andySigler Mar 9, 2023
b192654
slowing to 50mm/sec reduces noise on scale from moving air
andySigler Mar 9, 2023
38efdfa
use encoders after pick-up-tip
andySigler Mar 9, 2023
c2c586b
adds return tip option; multiple tip-racks
andySigler Mar 10, 2023
0506d50
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 10, 2023
3c805b7
add hard-coded vial offset to get around App bug
andySigler Mar 10, 2023
d38e15c
adds script for finding labware offset
andySigler Mar 10, 2023
443b645
option to skip blank readings
andySigler Mar 10, 2023
7712c41
correct decimal place on uL calculations
andySigler Mar 10, 2023
c7b4836
keep tip farther away from liquid during blank measurements
andySigler Mar 10, 2023
77e312c
also limit dispense volumes to 90% of pipette max
andySigler Mar 11, 2023
60bb06e
print final results at end
andySigler Mar 11, 2023
9dfacd2
fix(engine): subtract nominal overlap when calculating nominal tip le
andySigler Mar 11, 2023
f4df556
slow down acceleration/discontinuity; hard-code homing speeds to be f…
andySigler Mar 11, 2023
b6fee74
testing went well
andySigler Mar 11, 2023
1bba25f
linting
andySigler Mar 11, 2023
11d5618
adds inspect and skip-mix arguments
andySigler Mar 13, 2023
950580e
better printout during test run
andySigler Mar 13, 2023
ba66801
removing warnings about not having tip-length calibration on OT3
andySigler Mar 13, 2023
d5c1ff4
adds starting-tip
andySigler Mar 13, 2023
7dfda1f
use same submerge/retract distances for aspirate and dispense
andySigler Mar 13, 2023
a962f26
adds pipette temperature readings
andySigler Mar 13, 2023
7b67bb7
--inspect speeds all measurements up
andySigler Mar 13, 2023
c32cc56
use all of plunger
andySigler Mar 14, 2023
a0d122c
test more options in makefile
andySigler Mar 14, 2023
b788ba0
increase p1000-single pick-up-current from 0.15 to 0.25
andySigler Mar 14, 2023
f6250ca
fix bug where 1x trial would break CV calculations
andySigler Mar 14, 2023
aa05161
wip: tuning mix so droplets aren't created
andySigler Mar 14, 2023
bee277b
increase T50 leading-air-gaps
andySigler Mar 14, 2023
caf5f9c
update liquid-class settings to match tested values from Nick
andySigler Mar 14, 2023
74159e2
adds --user-volumes
andySigler Mar 14, 2023
7d278d5
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 14, 2023
b2b6478
merge in edge
andySigler Mar 14, 2023
f4c6c73
raise top plunger positions from 0.5 to 0.0
andySigler Mar 15, 2023
2d88a81
reduce amount of logs during measurement delay
andySigler Mar 15, 2023
051e4e2
load latest data 100ms after finishing previous data
andySigler Mar 16, 2023
a2c5e8d
different speeds for retract/submerge
andySigler Mar 16, 2023
88c032f
combine all stable samples into one segment to average; reduce delay …
andySigler Mar 16, 2023
cdddd49
reduct p1000 leading-air-gap from 32 to 16, so only one bubble is eje…
andySigler Mar 16, 2023
c1e3682
change skip-mix and skip-blank args to mix and blank
andySigler Mar 16, 2023
e2b71d3
linting!
andySigler Mar 16, 2023
a3cffa0
remove waiting for user to confirmware labware offsets
andySigler Mar 16, 2023
8434e0b
removes unnecessary changes to api
andySigler Mar 16, 2023
29c443f
remove reading temp-humidity within script
andySigler Mar 16, 2023
45de6e4
remove blow-out with volume from api
andySigler Mar 16, 2023
088a2aa
plate blow-out with micro-liters in hardware-testing script
andySigler Mar 16, 2023
c45f905
linting!
andySigler Mar 16, 2023
ac217b3
remove shared-data changes
andySigler Mar 16, 2023
21fa0b5
delete temp script for testing labware offsets
andySigler Mar 16, 2023
bc21c3d
Merge branch 'edge' into feat-hardware-testing-grav-script-on-ot3
andySigler Mar 16, 2023
71baa82
remove tip-overlap bug fix
andySigler Mar 16, 2023
67e3a03
fix broken test
andySigler Mar 16, 2023
088c503
fix makefile incorrectly calling gravimetric script
andySigler Mar 16, 2023
7a0d2c9
json uses 2-space indentation
andySigler Mar 16, 2023
3fd06ff
format-js
andySigler Mar 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing warnings about not having tip-length calibration on OT3
andySigler committed Mar 13, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ba668016566caf1e8f06b5051972ffa412ed575f
2 changes: 1 addition & 1 deletion api/src/opentrons/calibration_storage/ot2/tip_length.py
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ def tip_lengths_for_pipette(
pass
return tip_lengths
except FileNotFoundError:
log.warning(f"Tip length calibrations not found for {pipette_id}")
log.info(f"Tip length calibrations not found for {pipette_id}")
return tip_lengths


2 changes: 1 addition & 1 deletion api/src/opentrons/calibration_storage/ot3/tip_length.py
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ def tip_lengths_for_pipette(
pass
return tip_lengths
except FileNotFoundError:
log.warning(f"Tip length calibrations not found for {pipette_id}")
log.info(f"Tip length calibrations not found for {pipette_id}")
return tip_lengths