Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): Convert GEN1/GEN2 pipettes to the new shared-data schema #12148

Merged
merged 13 commits into from
Feb 14, 2023

Conversation

Laura-Danielle
Copy link
Contributor

Overview

Closes #RLIQ 250. Check out this confluence doc for further information on how to use the script for building new pipette models.

Changelog

  • Update shared data definitions for GEN1/GEN2 pipettes
  • Add in a script to automate creating new pipette configuration definitions

Review requests

Double check the script. Let me know if anything doesn't make sense.

Risk assessment

Low. Not being currently used.

@Laura-Danielle Laura-Danielle requested a review from a team February 14, 2023 04:19
@Laura-Danielle Laura-Danielle requested a review from a team as a code owner February 14, 2023 04:19
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #12148 (2f01879) into edge (cf39536) will decrease coverage by 0.50%.
The diff coverage is 6.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12148      +/-   ##
==========================================
- Coverage   74.23%   73.74%   -0.50%     
==========================================
  Files        2190     1433     -757     
  Lines       60701    47662   -13039     
  Branches     6474     2984    -3490     
==========================================
- Hits        45063    35149    -9914     
+ Misses      14106    12061    -2045     
+ Partials     1532      452    -1080     
Flag Coverage Δ
app 48.16% <ø> (-24.29%) ⬇️
notify-server 89.13% <ø> (ø)
protocol-designer 45.89% <ø> (ø)
shared-data 75.18% <6.63%> (-9.97%) ⬇️
step-generation 88.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...obot-server/robot_server/protocols/dependencies.py 100.00% <ø> (ø)
robot-server/robot_server/runs/dependencies.py 100.00% <ø> (ø)
robot-server/robot_server/settings.py 100.00% <ø> (ø)
...s_shared_data/pipette/scripts/build_json_script.py 0.00% <0.00%> (ø)
.../python/opentrons_shared_data/pipette/load_data.py 96.15% <100.00%> (+3.05%) ⬆️
...pentrons_shared_data/pipette/pipette_definition.py 91.93% <100.00%> (+0.63%) ⬆️
app-shell/src/config/migrate.ts 93.18% <0.00%> (-0.70%) ⬇️
shared-data/js/helpers/index.ts 78.15% <0.00%> (ø)
..._shared_data/protocol/models/protocol_schema_v6.py 100.00% <0.00%> (ø)
...organisms/LabwarePositionCheck/TipConfirmation.tsx
... and 761 more

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pathTo3D entries in geometry configs need to be sanitized, either to relative paths or to "json anchor paths" e.g. absolute paths relative to the data root that start with #
  • make sure we mark the gltf files binary in git

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also if we don't have a test that just schema checks everything we should add one

@Laura-Danielle
Copy link
Contributor Author

Oh also if we don't have a test that just schema checks everything we should add one

The schema checks happen in js at shared-data/js/__tests__/pipetteSchemaV2.test.ts which also happen to be failing cus I missed something from the schema 😉

@Laura-Danielle Laura-Danielle requested review from a team as code owners February 14, 2023 17:45
@Laura-Danielle Laura-Danielle requested review from b-cooper and sfoster1 and removed request for a team February 14, 2023 17:45
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me generally, though I think maybe we want a # anchor in the gltf paths? could go either way

@Laura-Danielle Laura-Danielle merged commit 518dd25 into edge Feb 14, 2023
@Laura-Danielle Laura-Danielle deleted the RLIQ-250-convert-ot2-pipettes-schema-v2 branch February 14, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants