-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data): Convert GEN1/GEN2 pipettes to the new shared-data schema #12148
feat(shared-data): Convert GEN1/GEN2 pipettes to the new shared-data schema #12148
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12148 +/- ##
==========================================
- Coverage 74.23% 73.74% -0.50%
==========================================
Files 2190 1433 -757
Lines 60701 47662 -13039
Branches 6474 2984 -3490
==========================================
- Hits 45063 35149 -9914
+ Misses 14106 12061 -2045
+ Partials 1532 452 -1080
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pathTo3D
entries in geometry configs need to be sanitized, either to relative paths or to "json anchor paths" e.g. absolute paths relative to the data root that start with#
- make sure we mark the gltf files binary in git
shared-data/pipette/definitions/2/geometry/eight_channel/p300/1_0.json
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/pipette/build_json_script.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/pipette/build_json_script.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh also if we don't have a test that just schema checks everything we should add one
The schema checks happen in js at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me generally, though I think maybe we want a #
anchor in the gltf paths? could go either way
Overview
Closes #RLIQ 250. Check out this confluence doc for further information on how to use the script for building new pipette models.
Changelog
Review requests
Double check the script. Let me know if anything doesn't make sense.
Risk assessment
Low. Not being currently used.