fix(api): ensure critical points are acceptable for a 96 channel #11890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the original calculations for 8 channel pipttes in the Y direction for both XY_CENTER and FRONT_NOZZLE. This logic works because the Y element equals the number of channels. That is no longer the case for the 96 channels so we need to temporarily modify the calculation so that the critical point calculation is correct for the 96 channel AND 8 channel. The long term fix is to add critical point information for all pipette nozzles as individual points/positions.
Codecov Report
@@ Coverage Diff @@
## RLIQ-131-support-96-channel #11890 +/- ##
===============================================================
- Coverage 74.37% 74.27% -0.10%
===============================================================
Files 2140 2122 -18
Lines 60117 58898 -1219
Branches 6624 6218 -406
===============================================================
- Hits 44712 43748 -964
+ Misses 13863 13684 -179
+ Partials 1542 1466 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
Dec 15, 2022
| offsets[1] | ||
| - INTERNOZZLE_SPACING_MM * (self._config.channels.as_int - 1) | ||
| ), | ||
| offsets[1] - y_offset_by_spacing, |
There was a problem hiding this comment.
something's wrong here - FRONT_NOZZLE and XY_CENTER shouldn't have the same y offset. should this be x_offset_by_spacing * 2?
There was a problem hiding this comment.
yep that was definitely an oversight.
Laura-Danielle
added a commit
that referenced
this pull request
Dec 16, 2022
Laura-Danielle
added a commit
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We were using the original calculations for 8 channel pipttes in the Y direction for both XY_CENTER and FRONT_NOZZLE. This logic works because the Y element equals the number of channels. That is no longer the case for the 96 channels so we need to temporarily modify the calculation so that the critical point calculation is correct for the 96 channel AND 8 channel. The long term fix is to add critical point information for all pipette nozzles as individual points/positions.
Changelog
Pipetteinstrument tests to work for both pipette objects.Risk assessment
Low. Should only change behavior for 96 channel.