-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflows): upgrade action versions and ubuntu in workflows #11376
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #11376 +/- ##
==========================================
- Coverage 74.62% 74.40% -0.23%
==========================================
Files 2023 2041 +18
Lines 56438 56809 +371
Branches 5389 5437 +48
==========================================
+ Hits 42116 42266 +150
- Misses 13098 13315 +217
- Partials 1224 1228 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@y3rsh it looks like the runner is now using 3.10 instead of 3.7 to create the virtualenv which is breaking things:
now i'm not sure why that is, but i think that's what is breaking things. we shouldn't have to, and should not, change the code - would you mind reverting that commit? |
@y3rsh it looks like this: #9708 now needs to be not opted out of by CI. this is set in ci by i think we should make either
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since CI is still green and assets have been tested and confirmed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, looks good to me. Nice work!
Overview
ubuntu-18.04
runners to useubuntu-22.04
runners.Review requests
Risk assessment
🟨 Medium
6.1.0_alpha.3
release so we can validate on thebeta
tag?