Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): upgrade action versions and ubuntu in workflows #11376

Merged
merged 20 commits into from
Aug 24, 2022

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Aug 22, 2022

Overview

  • Due to ubuntu-18.04 runners getting deprecated, upgrade workflows using ubuntu-18.04 runners to use ubuntu-22.04 runners.
  • Update the versions of the the GitHub actions we consume to the latest.

Review requests

  • anything missing?
  • other risks?

Risk assessment

🟨 Medium

  • Some parts of the workflows only run on release.
  • Merge after 6.1.0_alpha.3 release so we can validate on the beta tag?

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #11376 (582da5c) into edge (5d2f483) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11376      +/-   ##
==========================================
- Coverage   74.62%   74.40%   -0.23%     
==========================================
  Files        2023     2041      +18     
  Lines       56438    56809     +371     
  Branches     5389     5437      +48     
==========================================
+ Hits        42116    42266     +150     
- Misses      13098    13315     +217     
- Partials     1224     1228       +4     
Flag Coverage Δ
app 74.70% <ø> (-0.44%) ⬇️
components 53.05% <ø> (ø)
g-code-testing 97.13% <ø> (ø)
hardware 59.17% <ø> (ø)
hardware-testing 44.53% <ø> (-2.90%) ⬇️
labware-library 49.74% <ø> (ø)
notify-server 89.17% <ø> (ø)
protocol-designer 45.81% <ø> (ø)
react-api-client 82.98% <ø> (ø)
shared-data 86.11% <ø> (+0.03%) ⬆️
step-generation 88.39% <ø> (ø)
update-server 73.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/molecules/JogControls/index.tsx 0.00% <0.00%> (-100.00%) ⬇️
app/src/molecules/JogControls/DirectionControl.tsx 22.22% <0.00%> (-63.50%) ⬇️
app/src/molecules/JogControls/StepSizeControl.tsx 0.00% <0.00%> (-60.00%) ⬇️
app/src/molecules/JogControls/ControlContainer.tsx 50.00% <0.00%> (-50.00%) ⬇️
app/src/organisms/ChangePipette/index.tsx 5.81% <0.00%> (-0.36%) ⬇️
shared-data/js/constants.ts 100.00% <0.00%> (ø)
app/src/organisms/CalibrationPanels/MeasureTip.tsx 66.66% <0.00%> (ø)
app/src/organisms/CalibrationPanels/SaveZPoint.tsx 97.29% <0.00%> (ø)
...pp/src/organisms/CalibrationPanels/SaveXYPoint.tsx 79.16% <0.00%> (ø)
.../src/organisms/CalibrationPanels/MeasureNozzle.tsx 70.96% <0.00%> (ø)
... and 27 more

@sfoster1
Copy link
Member

@sfoster1
Copy link
Member

@y3rsh it looks like the runner is now using 3.10 instead of 3.7 to create the virtualenv which is breaking things:

Pipfile: /home/runner/work/opentrons/opentrons/api/Pipfile
Using /usr/bin/python3 (3.10.4) to create virtualenv...

now i'm not sure why that is, but i think that's what is breaking things. we shouldn't have to, and should not, change the code - would you mind reverting that commit?

@sfoster1
Copy link
Member

@y3rsh it looks like this: #9708 now needs to be not opted out of by CI.

this is set in ci by .github/actions/setup/action.yaml. it's set by an action input that defaults to empty.

i think we should make either

  • (preferred) Change the action so that if the input is unset, it doesn't specify the environment override at all, and just calls make -C ${{ inputs.project }} setup rather than make -C ${{ inputs.project}} setup OT_VIRTUALENV_VERSION=, which will allow the default in the python.mk script to get set
  • change the action to have that input default to 3.7, which I don't love because then it's a second source of truth to python.mk, but should work

@y3rsh y3rsh marked this pull request as ready for review August 23, 2022 01:51
@y3rsh y3rsh requested review from a team as code owners August 23, 2022 01:51
@y3rsh y3rsh requested review from koji and removed request for a team August 23, 2022 01:51
@y3rsh
Copy link
Member Author

y3rsh commented Aug 23, 2022

All builds created from this PR installed.

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since CI is still green and assets have been tested and confirmed

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, looks good to me. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants