feat(app): adding support for v6 commands in run log #11254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #11254 +/- ##
=======================================
Coverage 73.84% 73.84%
=======================================
Files 2090 2090
Lines 57836 57929 +93
Branches 5867 5889 +22
=======================================
+ Hits 42708 42779 +71
- Misses 13843 13862 +19
- Partials 1285 1288 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ecormany
approved these changes
Jul 28, 2022
| "move_to_well": "Moving to {{well_name}} of {{labware}} in {{labware_location}}", | ||
| "move_relative": "Moving {{distance}} mm along {{axis}} axis", | ||
| "move_to_coordinates": "Moving to (X: {{x}}, Y: {{y}}, Z: {{z}})", | ||
| "home_gantry": "Homing the following axes: Gantry X, Gantry Y, Left Pipette Mount Z, Right Pipette Mount Z, Left Pipette Plunger, Right Pipette Plunger", |
There was a problem hiding this comment.
This is pretty verbose. If it's homing everything, could say something like Homing all gantry, pipette, and plunger axes. Also, right pipette is axis A, left plunger is B, right plunger is C.
Fine to ship for now though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for all previously unsupported v6 commands in the Run Log
Changelog
Add the following commands:
Review requests
Look over new strings for clarity, test it out!
Risk assessment
Low