Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Heater Shaker Firmware Level Emulator #11121
feat(api): Heater Shaker Firmware Level Emulator #11121
Changes from 3 commits
4d0926f
0b5bf29
dde5f4a
a6c497f
1ed6115
0926e14
4beaaca
26f98cd
8f694cf
3fb1547
8f46bc9
cfe7d93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the intended API contract of the Heater-Shaker hardware controller? If I do
hs.start_set_temperature(...)
and then dot = hs.target_temperature
, I'm not guaranteed to get back what I just set?If yes: I think this is surprising, and we need to document it in the
HeaterShaker
class. Doesn't have to happen in this PR, but I'd like confirmation/consensus.If no: this indicates a bug, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, it makes sense that target temp should be set and it would be just current temp that hasn't update yet.
Looking into it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left out a line. Fixing it in a followup commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4beaaca