-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): pause protocol execution if door is opened #11021
Conversation
…mplification" This reverts commit 1f5f377.
Codecov Report
@@ Coverage Diff @@
## edge #11021 +/- ##
==========================================
- Coverage 73.80% 73.79% -0.01%
==========================================
Files 2076 2076
Lines 57318 57351 +33
Branches 5729 5734 +5
==========================================
+ Hits 42302 42322 +20
- Misses 13778 13791 +13
Partials 1238 1238
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-pause-protocol-door-open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending robot testing. Will approve once someone can work through these smoke tests
JSONv6, door pause setting off:
- Door open does nothing during LPC
- Door close does nothing during LPC
- Door open does nothing during protocol run
- Door close does nothing during protocol run
JSONv6, door pause setting on:
- Door open does nothing during LPC
- Door close does nothing during LPC
- Door open during protocol run pauses
- {"actionType": "play"} errors while door is still open
- Door close followed by {"actionType": "play"} resumes the run
PAPIv2, door pause setting off:
- Door open does nothing during LPC
- Door close does nothing during LPC
- Door open does nothing during protocol run
- Door close does nothing during protocol run
PAPIv2, door pause setting on:
- Door open does nothing during LPC
- Door close does nothing during LPC
- Door open during protocol run pauses
- {"actionType": "play"} errors while door is still open
- Door close followed by {"actionType": "play"} resumes the run
Edit: All above tested by @SyntaxColoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the code, but I've run through @mcous's tests, and this appears to be working as specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @SyntaxColoring's testing
Overview
Closes #9125
Adds pausing protocol execution if a door state hardware notification is detected to protocol engine. Protocol Engine hardware action and handlers renamed to reflect dealing with door events only, along with simplification of the door change action.
Changelog
DoorStateNotification
Review requests
Risk assessment
Low, mostly refactoring and renaming with only small and contained functionality added