Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(protocol-designer, labware-library, components): explicitly define aws region in deploy step #10959

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

shlokamin
Copy link
Member

Overview

duplicate of #10896 but wanna commit into edge so deploys actually work.

Review requests

  • confirm that the deploy to s3 steps of the protocol-designer, labware-library, and components succeeds without erroring with exit code 255

Risk assessment

low

@shlokamin shlokamin marked this pull request as ready for review June 30, 2022 15:25
@shlokamin shlokamin requested a review from a team as a code owner June 30, 2022 15:25
@shlokamin shlokamin requested a review from b-cooper June 30, 2022 15:25
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #10959 (6001c82) into edge (8a70b53) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #10959   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files        2076     2076           
  Lines       57328    57328           
  Branches     5727     5727           
=======================================
  Hits        42300    42300           
  Misses      13789    13789           
  Partials     1239     1239           
Flag Coverage Δ
components 52.77% <ø> (ø)
labware-library 49.74% <ø> (ø)
protocol-designer 46.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shlokamin shlokamin merged commit b28d990 into edge Jun 30, 2022
@shlokamin shlokamin deleted the ci_add-explicit-aws-region branch June 30, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants