[Pending] feat(app) App feat add get robotName #10871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to add a function to get a robotName from API instead of using rename function's return.
Codecov Report
@@ Coverage Diff @@
## release_6.0.0 #10871 +/- ##
=================================================
- Coverage 73.83% 73.80% -0.04%
=================================================
Files 2158 2161 +3
Lines 58349 58659 +310
Branches 5963 6067 +104
=================================================
+ Hits 43084 43291 +207
- Misses 13991 14052 +61
- Partials 1274 1316 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
changed the title
koji
changed the title
koji
commented
Jun 23, 2022
Comment on lines
+1
to
7
| export interface CurrentRobotName { | ||
| name: string | ||
| } | ||
|
|
||
| export interface UpdatedRobotName { | ||
| name: string | ||
| } |
There was a problem hiding this comment.
[Question to reviewers]
Should I combine these two interfaces into one like RobotName?
RobotName might be vague? In addition, we use robotName in many components so maybe a different name would be better?
koji
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is for the robot rename function and this PR will be used by #10723 to retrieve the new robot name.
This PR uses the API
/server/nameGET methodChangelog
api-clientreact-api-clientReview requests
This PR is similar to
runsandprotocolswithGETso the key is that the changes follow the existing coding style and usage ofreact-queryWould like to get reviewers' thought on interface that I commented
This function only works with an OT-2 (not work with robot-server)
I checked
useRobotName()worked in RenameSlideout component.Risk assessment