Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): temporary redirect to devices page #10712

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

koji
Copy link
Contributor

@koji koji commented Jun 9, 2022

Avoid the issue that is in #10709

Overview

This is a temporary solution to for the issue in #10709 and fixes #10720

Changelog

  • Change the redirect path to /devices.

Review requests

  • After renaming a robot, the app redirect to the devices landing page

Risk assessment

low

@koji koji requested a review from a team as a code owner June 9, 2022 21:04
@koji koji requested review from b-cooper, vabruzzo, aptrons22 and jerader and removed request for a team June 9, 2022 21:04
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #10712 (05f450a) into edge (3f8e0cd) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #10712      +/-   ##
==========================================
- Coverage   74.12%   73.83%   -0.30%     
==========================================
  Files        2110     2153      +43     
  Lines       57079    58220    +1141     
  Branches     5763     5954     +191     
==========================================
+ Hits        42311    42984     +673     
- Misses      13526    13965     +439     
- Partials     1242     1271      +29     
Flag Coverage Δ
app 71.60% <0.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...edTab/AdvancedTabSlideouts/RenameRobotSlideout.tsx 68.00% <0.00%> (ø)
app-shell/src/protocol-storage/file-system.ts 78.18% <0.00%> (ø)
app-shell/src/labware/index.ts 83.58% <0.00%> (ø)
discovery-client/src/store/reducer.ts 91.66% <0.00%> (ø)
discovery-client/src/store/selectors.ts 100.00% <0.00%> (ø)
app-shell/src/system-info/usb-devices.ts 84.61% <0.00%> (ø)
app-shell/src/update.ts 96.96% <0.00%> (ø)
app-shell/src/http.ts 25.71% <0.00%> (ø)
app-shell/src/ui.ts 0.00% <0.00%> (ø)
app-shell/src/config/migrate.ts 91.66% <0.00%> (ø)
... and 34 more

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ◀️

@koji koji merged commit 4eaedbe into edge Jun 10, 2022
@koji koji deleted the app_fix-robot-rename-temp-patch branch August 23, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0-feedback Feedback for the 6.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.0 Feedback: white screen after renaming the robot
3 participants