refactor(update-server): Type update-server more strictly #10458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
added
robot-svcs
Codecov Report
@@ Coverage Diff @@
## edge #10458 +/- ##
==========================================
- Coverage 73.64% 73.64% -0.01%
==========================================
Files 2134 2135 +1
Lines 57366 57376 +10
Branches 5754 5754
==========================================
+ Hits 42249 42253 +4
- Misses 13913 13919 +6
Partials 1204 1204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SyntaxColoring
commented
May 25, 2022
| hostname = loop.run_until_complete(name_management.setup_hostname()) | ||
| hostname = loop.run_until_complete(name_management.set_up_static_hostname()) |
There was a problem hiding this comment.
This change is intentional. setup_hostname() got renamed to set_up_static_hostname() in #10219.
SyntaxColoring
commented
May 25, 2022
| @@ -53,9 +53,9 @@ test: | |||
|
|
|||
| .PHONY: lint | |||
| lint: | |||
| $(python) -m mypy otupdate | |||
There was a problem hiding this comment.
In my experience, running mypy first makes for the nicest dev experience because its errors tend to be the ones that matter most.
mcous
reviewed
May 26, 2022
sfoster1
approved these changes
May 26, 2022
|
Tested again after that last commit that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances static type-checking in
update-server.Changelog
aiohttp.web.Requestclass existed.apiandrobot-serverpackages.mypy.iniand leave a# TODOcomment for them. This follows the pattern set byapiandrobot-server.Review requests
Go over the code and make sure that the changes are only to type annotations, unless I've noted otherwise.
I've tested this on a real OT-2 by making sure that it can still apply an update file and that it can still accept robot renames. I don't have an OT-3 environment to test on.
Risk assessment
Low as long as I haven't accidentally affected the runtime behavior of anything.