Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Update robot rename rule #10318

Merged
merged 3 commits into from
May 17, 2022
Merged

fix(app): Update robot rename rule #10318

merged 3 commits into from
May 17, 2022

Conversation

koji
Copy link
Contributor

@koji koji commented May 17, 2022

Overview

This will fix #10214

The new rule is that allows users to use a-z, A-Z and 0-9.

regex
/^([a-zA-Z0-9]{0,35})$/
https://regexr.com/

Screen Shot 2022-05-17 at 2 33 27 PM

Changelog

  • Updated RenameRobotSlideout regex
  • Updated the test for a new regex pattern
  • Cleaned up device_settings

Review requests

Risk assessment

low

koji added 3 commits May 17, 2022 13:58
@koji koji requested a review from b-cooper May 17, 2022 18:35
@koji koji marked this pull request as ready for review May 17, 2022 18:36
@koji koji requested a review from a team as a code owner May 17, 2022 18:36
@koji koji removed the request for review from a team May 17, 2022 18:36
@ecormany
Copy link
Contributor

user-facing text strings look good 👍

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #10318 (47fa8b5) into edge (678ba77) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #10318      +/-   ##
==========================================
+ Coverage   74.38%   74.40%   +0.01%     
==========================================
  Files        2122     2122              
  Lines       56225    56318      +93     
  Branches     5717     5756      +39     
==========================================
+ Hits        41824    41901      +77     
- Misses      13211    13221      +10     
- Partials     1190     1196       +6     
Flag Coverage Δ
app 71.16% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...edTab/AdvancedTabSlideouts/RenameRobotSlideout.tsx 68.00% <100.00%> (ø)
...p-shell/src/protocol-analysis/executeAnalyzeCli.ts 11.11% <0.00%> (-8.89%) ⬇️
...rganisms/Devices/ProtocolRun/ProtocolRunHeader.tsx 88.53% <0.00%> (-1.47%) ⬇️
...rganisms/Devices/hooks/useProtocolDetailsForRun.ts 92.30% <0.00%> (-1.03%) ⬇️
app-shell/src/protocol-analysis/index.ts 100.00% <0.00%> (ø)
app/src/organisms/ChooseProtocolSlideout/index.tsx 87.50% <0.00%> (+4.16%) ⬆️
...ms/ChooseRobotSlideout/useCreateRunFromProtocol.ts 57.14% <0.00%> (+10.47%) ⬆️

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📛

@koji koji merged commit ecd77ef into edge May 17, 2022
@koji koji deleted the app_fix-robot-rename-regex branch May 17, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional client-side restrictions on robot names to protect against robot-side bugs
3 participants