Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 5.1.0-beta.0 #10029

Merged
merged 6 commits into from
Apr 21, 2022
Merged

chore(release): 5.1.0-beta.0 #10029

merged 6 commits into from
Apr 21, 2022

Conversation

b-cooper
Copy link
Contributor

Overview

Bump to 5.1.0-beta.0

Changelog

  • bumped versions to 5.1.0-beta.0
  • updated release notes in app-shell and api with basic information

Review requests

  • release notes look reasonable for a first pass?
  • Changelogs look reasonable?

Risk assessment

low

@b-cooper b-cooper requested review from a team as code owners April 20, 2022 23:46
@b-cooper b-cooper requested review from mcous and removed request for a team April 20, 2022 23:46
@codecov
Copy link

codecov bot commented Apr 20, 2022 •
edited
Loading

Codecov Report

Merging #10029 (293f65b) into edge (cf4e9ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #10029   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files        2108     2108           
  Lines       55336    55336           
  Branches     5620     5620           
=======================================
  Hits        41326    41326           
  Misses      12872    12872           
  Partials     1138     1138
Flag Coverage Δ
app 71.42% <ø> (ø)
components 52.80% <ø> (ø)
labware-library 49.74% <ø> (ø)
notify-server 89.17% <ø> (ø)
protocol-designer 44.88% <ø> (ø)
react-api-client 80.76% <ø> (ø)
step-generation 86.49% <ø> (ø)
update-server 73.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b-cooper b-cooper added the release 🚢 used for release prs label Apr 20, 2022
ecormany
ecormany reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple typo corrections for the beta readme files.

api/release-notes.md Outdated Show resolved Hide resolved
app-shell/build/release-notes.md Show resolved Hide resolved
app-shell/build/release-notes.md Show resolved Hide resolved
mcous
mcous approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📜

bndo
bndo approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@bndo bndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@b-cooper b-cooper merged commit 4572f85 into edge Apr 21, 2022
@b-cooper b-cooper deleted the chore_bump-5.1.0-beta.0 branch April 21, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecormany ecormany ecormany left review comments

@mcous mcous mcous approved these changes

@laviera laviera laviera approved these changes

@bndo bndo bndo approved these changes

Assignees
No one assigned
Labels
release 🚢 used for release prs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@b-cooper @bndo @ecormany @laviera @mcous