Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD: remove skipped migration e2e tests #9852

Closed
shlokamin opened this issue Apr 1, 2022 · 0 comments · Fixed by #10849
Closed

PD: remove skipped migration e2e tests #9852

shlokamin opened this issue Apr 1, 2022 · 0 comments · Fixed by #10849
Labels
json-v6 Issues related to JSON Protocol Schema v6 protocol designer Affects the `protocol-designer` project

Comments

@shlokamin
Copy link
Member

Overview

Currently PD migration e2e tests (protocol-designer/cypress/integration/migrations.spec.js) are being skipped while JSON schema v6 support gets fully implemented. Once the liquids key is added to PD, we should be able to generate new v6 fixtures and un skip the migration tests.

Note: previously migrations would conditionally bump schema versions, now we ALWAYS bump to schema v6, so our new assertion fixtures must reflect this.

Acceptance criteria

PD migration tests are running and passing
@shlokamin shlokamin added protocol designer Affects the `protocol-designer` project json-v6 Issues related to JSON Protocol Schema v6 labels Apr 1, 2022
shlokamin added a commit that referenced this issue Jun 21, 2022
@shlokamin
test(protocol-designer): turn on cypress e2e migration test
63916f3 
closes #9852
@shlokamin shlokamin mentioned this issue Jun 21, 2022
Merged
shlokamin added a commit that referenced this issue Jun 28, 2022
@shlokamin
test(protocol-designer): turn on cypress e2e migration tests (#10849)
84778fc 
closes #9852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
json-v6 Issues related to JSON Protocol Schema v6 protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(protocol-designer): turn on cypress e2e migration tests Opentrons/opentrons
1 participant
@shlokamin