Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LC: load and save integration test case for custom tiprack #7697

Closed
IanLondon opened this issue Apr 21, 2021 · 0 comments · Fixed by #7947
Closed

LC: load and save integration test case for custom tiprack #7697

IanLondon opened this issue Apr 21, 2021 · 0 comments · Fixed by #7947
Assignees
@IanLondon
Labels
labware creator

Comments

@IanLondon
Copy link
Contributor

labware-library/src/labware-creator/__tests__/loadAndSaveIntegration.test.ts is an integration test that loads a labware def and immediately saves it. It expects the saved definition to match the loaded definition, with certain exceptions (see comments in the file)

We have 2 test cases: for 96-plate, and a 12-trough. We should add a new test case for tiprack (and if we have time, for aluminum block and tube rack etc too, we don't have full coverage here!! Those probably should be a separate ticket.)
@IanLondon IanLondon self-assigned this Jun 15, 2021
@IanLondon IanLondon mentioned this issue Jun 15, 2021
Merged
IanLondon added a commit that referenced this issue Jun 21, 2021
@IanLondon
feat(labware-creator): export and import tiprack defs (#7947)
a90e66d 
Closes #7696 and closes #7697

* make LC assume tiprack is snug upon import
* re-generate fixture_tiprack_300_ul via createRegularLabware fn with more consistent numbers (it seems to have been written manually) and update related tests/snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanLondon IanLondon

Labels
labware creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(labware-creator): export and import tiprack defs Opentrons/opentrons
1 participant
@IanLondon