Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interface for running protocol files #7644

Closed
1 of 3 tasks
mcous opened this issue Apr 15, 2021 · 0 comments · Fixed by #7757
Closed
1 of 3 tasks

Create interface for running protocol files #7644

mcous opened this issue Apr 15, 2021 · 0 comments · Fixed by #7757
Assignees
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Milestone

Comments

@mcous
Copy link
Contributor

mcous commented Apr 15, 2021

Overview

As part of the overall Protocol Engine project, we need a system component with the job of interpreting our various types of protocol files in order to hand execution responsibility off to other components properly.

Acceptance criteria

  • Create an abstract ProtocolFileRunner with two concrete implementations
    • PythonFileRunner
    • JsonFileRunner
    • (exact names not important, can improvise)
  • Create a factory that accepts some sort of protocol file value object and returns one of the two instances according to file type
    • Requirement removed due to lack of endpoint wireup at this time
  • Methods of the interface can be left out of scope, but speculative ones along the lines of load, play, pause, stop are probably ok
@mcous mcous added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Apr 15, 2021
@mattwelch mattwelch added this to the CPX Sprint 31 milestone Apr 20, 2021
@mcous mcous self-assigned this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants