fix(app): full-width jog controls #6970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
added
app
sfoster1
requested review from
Laura-Danielle and
IanLondon
and removed request for
a team
b-cooper
reviewed
Nov 11, 2020
There was a problem hiding this comment.
This is a good change, the same symptom is already partially addressed in my PR #6962 , which adds styleProps to the JogControl component. This way each instance of the JogControls component can decide how to position itself within its parent. I prefer this to hard coding width="100%" into the component definition. After #6962 merges it should be a quick rebase if you agree.
The jog controls were not wide enough in MeasureTip and MeasureNozzle, where they have only Z displayed. Use the new styled props to specify width=100%, which fixes the issue.
sfoster1
force-pushed
the
app_fix-jog-layout-in-measure-screens
branch
from
c8fdd48 to
b4cf09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jog controls were in MeasureTip and MeasureNozzle weren't expanding to their parent properly; give them a width=100%.
Testing
Check the MeasureTip and MeasureNozzle screens (doesn't matter if in cal check or tip length, they're invariant in this regard) and make sure the jog controls look right.