Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration Integration: bug: cal data isn't properly fetched on session end #6747

Closed
sfoster1 opened this issue Oct 13, 2020 · 0 comments · Fixed by #6757
Closed

Calibration Integration: bug: cal data isn't properly fetched on session end #6747

sfoster1 opened this issue Oct 13, 2020 · 0 comments · Fixed by #6757
Assignees
@ahiuchingau
Labels
app Affects the `app` project bug

Comments

@sfoster1
Copy link
Member

Tip length and pipette offset calibrations are intended to be fetched in the app when a redux action of type SESSION_DELETE_SUCCESS hits the stream. The epics that implement this (in app/src/calibration/pipette-offset and app/src/calibration/tip-length) trigger properly and emit an action with the proper action type, but the action payload - which includes things like the robot name to actually query - is malformed, so the endpoints never actually get hit.

Also, those epics should probably trigger on the DELETE_SESSION action, because the various flows that do calibration actually clear their modals then and render a spinner on the button that triggers them while the delete proceeds. If we continue to trigger the refetch on DELETE_SESSION_SUCCESS, until the delete ends (and the delete incurs some robot motion so it could be a while) we won't see updated data.

Let's fix both these issues.
@sfoster1 sfoster1 added app Affects the `app` project bug labels Oct 13, 2020
@ahiuchingau ahiuchingau self-assigned this Oct 13, 2020
sfoster1 added a commit that referenced this issue Oct 13, 2020
@sfoster1
fix(app): fix fetch-on-session-end epics for POC, TLC
92e3af4 
The epics to fetch pipette offset calibration and tip length calibration
were using the wrong rxjs operators to emit their actions, and
consequently would fire at the right times but not actually incur a
fetch from the robot.

Closes #6747
@sfoster1 sfoster1 mentioned this issue Oct 13, 2020
Merged
sfoster1 added a commit that referenced this issue Oct 14, 2020
@sfoster1 @ahiuchingau
fix(app): fix fetch-on-session-end epics for POC, TLC (#6757)
7124bd9 
The epics to fetch pipette offset calibration and tip length calibration
were using the wrong rxjs operators to emit their actions, and
consequently would fire at the right times but not actually incur a
fetch from the robot.

In addition, the UI works much better if the data is fetched when the
session delete _starts_ rather than completes successfully, since most
session wizards go away when the delete begins and therefore let the
user see the places where the data goes.

Closes #6747

Co-authored-by: ahiuchingau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahiuchingau ahiuchingau

Labels
app Affects the `app` project bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(app): fix fetch-on-session-end epics for POC, TLC Opentrons/opentrons
2 participants
@sfoster1 @ahiuchingau