Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cal Overhaul FF: Remove on app side #6737

Closed
sfoster1 opened this issue Oct 12, 2020 · 0 comments
Closed

Cal Overhaul FF: Remove on app side #6737

sfoster1 opened this issue Oct 12, 2020 · 0 comments
Labels
app Affects the `app` project refactor

Comments

@sfoster1
Copy link
Member

sfoster1 commented Oct 12, 2020

Remove all the checks of the Config.enableCalibrationOverhaul feature flag on the app side, and all code and styles that are no longer used.

@sfoster1 sfoster1 added app Affects the `app` project refactor labels Oct 12, 2020
sfoster1 added a commit that referenced this issue Oct 16, 2020
Enable the previously under-development flows to support the new
calibration procedures for the OT-2.

The new development flows are based on a new session model, with a
limited number of endpoints that accept structured commands. The
middleware for this lives in app/src/sessions.

In addition, much more data about calibration is exposed via HTTP in
app/src/calibrations.

The new deck calibration doesn't have much that is different, but the
new pipette offset calibration and tip length calibration flows are
integrated in many different parts of the app ecosystem:
- In the attach pipette flow, you now calibrate pipette offset (and
possibly tip length, if necessary) in the attach flow
- There are also buttons for same in the pipettes card
- In the pre protocol flow, you now calibrate tip length for each kind
of tiprack used in your protocol, possibly also recalibrating pipette
offset if you recalibrate a tip length used for pipette offset
- You must have a pipette offset and deck calibration to enter the
protocol flows
- Robot calibration data is now exposed on the robots pages

Closes #6736, #6737
sfoster1 added a commit that referenced this issue Oct 16, 2020
Enable the previously under-development flows to support the new
calibration procedures for the OT-2.

The new development flows are based on a new session model, with a
limited number of endpoints that accept structured commands. The
middleware for this lives in app/src/sessions.

In addition, much more data about calibration is exposed via HTTP in
app/src/calibrations.

The new deck calibration doesn't have much that is different, but the
new pipette offset calibration and tip length calibration flows are
integrated in many different parts of the app ecosystem:
- In the attach pipette flow, you now calibrate pipette offset (and
possibly tip length, if necessary) in the attach flow
- There are also buttons for same in the pipettes card
- In the pre protocol flow, you now calibrate tip length for each kind
of tiprack used in your protocol, possibly also recalibrating pipette
offset if you recalibrate a tip length used for pipette offset
- You must have a pipette offset and deck calibration to enter the
protocol flows
- Robot calibration data is now exposed on the robots pages

Closes #6736, #6737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project refactor
Projects
None yet
Development

No branches or pull requests

1 participant