Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cal Overhaul: Check: Mark bad #6730

Closed
sfoster1 opened this issue Oct 12, 2020 · 0 comments
Closed

Cal Overhaul: Check: Mark bad #6730

sfoster1 opened this issue Oct 12, 2020 · 0 comments
Assignees
@Laura-Danielle
Labels
refactor robot server Affects the `robot-server` project

Comments

@sfoster1
Copy link
Member

sfoster1 commented Oct 12, 2020 •
edited
Loading

When calibration check detects through its normal thresholding that a specific calibration is bad, it should mark it bad in the serialized representation on disk and in memory in the hardware controller, with "source": "calibration_check" and a datestamp.
@sfoster1 sfoster1 added refactor robot server Affects the `robot-server` project labels Oct 12, 2020
@sfoster1 sfoster1 mentioned this issue Oct 12, 2020
Merged
@Laura-Danielle Laura-Danielle self-assigned this Oct 30, 2020
Laura-Danielle added a commit that referenced this issue Nov 4, 2020
@Laura-Danielle
feat(api): Mark calibrations as bad when determined they exceed thres…
8caa4f2 
…hold

closes #6730
@Laura-Danielle Laura-Danielle mentioned this issue Nov 4, 2020
Merged
Laura-Danielle added a commit that referenced this issue Nov 5, 2020
@Laura-Danielle
feat(api): Mark calibrations as bad when determined they exceed thres…
f2b746a 
…hold

closes #6730
Laura-Danielle added a commit that referenced this issue Nov 9, 2020
@Laura-Danielle
feat(api): Mark calibrations as bad when determined they exceed thres…
a6c078a 
…hold

closes #6730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Laura-Danielle Laura-Danielle

Labels
refactor robot server Affects the `robot-server` project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfoster1 @Laura-Danielle