Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipette Offset Calibration: Refactor chained commands into epics #6535

Closed
sfoster1 opened this issue Sep 14, 2020 · 0 comments · Fixed by #6561
Closed

Pipette Offset Calibration: Refactor chained commands into epics #6535

sfoster1 opened this issue Sep 14, 2020 · 0 comments · Fixed by #6561
Assignees
@b-cooper
Labels
app Affects the `app` project hmg hardware, motion, and geometry refactor
Milestone
HMG Sprint 18

Comments

@sfoster1
Copy link
Member

There are some commands that get issued in sequence without UI changes or user interaction. Each command is only valid when the server in the appropriate state, and so should be triggered when the results from the previous command arrive at the app; refactor these chained commands away from their current sleep()-based ordering into a proper epic.
@sfoster1 sfoster1 added app Affects the `app` project hmg hardware, motion, and geometry refactor labels Sep 14, 2020
@sfoster1 sfoster1 added this to the HMG Sprint 18 milestone Sep 14, 2020
@b-cooper b-cooper self-assigned this Sep 15, 2020
b-cooper added a commit that referenced this issue Sep 16, 2020
@b-cooper
fix(app): make cal commands chain instead of race
791064d 
In order to avoid various race conditions created by sequential commands being requested of the
robot during/before/after calibration sessions, create mechanism to ensure that they are dispatched
sequentially. Also ensure that wizard only closes on successful deletion, to avoid orphaned session.

Closes #6535
@b-cooper b-cooper mentioned this issue Sep 16, 2020
Merged
1 task
b-cooper added a commit that referenced this issue Sep 18, 2020
@b-cooper
fix(app): make cal commands chain instead of race (#6561)
20f01bc 
In order to avoid various race conditions created by sequential commands being requested of the
robot during/before/after calibration sessions, create mechanism to ensure that they are dispatched
sequentially. Also ensure that wizard only closes on successful deletion, to avoid orphaned session.

Closes #6535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-cooper b-cooper

Labels
app Affects the `app` project hmg hardware, motion, and geometry refactor
Projects
None yet
Milestone
HMG Sprint 18
Development

Successfully merging a pull request may close this issue.

fix(app): make cal commands chain instead of race Opentrons/opentrons
2 participants
@sfoster1 @b-cooper