Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD: implement createPresavedStepForm for Thermocycler step (TC State fields only) #5596

Closed
1 task
IanLondon opened this issue May 7, 2020 · 0 comments · Fixed by #5641
Closed
1 task

PD: implement createPresavedStepForm for Thermocycler step (TC State fields only) #5596

IanLondon opened this issue May 7, 2020 · 0 comments · Fixed by #5641
Assignees
@Kadee80
Labels
protocol designer Affects the `protocol-designer` project
Milestone
SPDDRS Sprint 8

Comments

@IanLondon
Copy link
Contributor

IanLondon commented May 7, 2020 •
edited
Loading

Implement createPresavedStepForm for stepType === 'thermocycler' -- set moduleId as in other module step forms.

This requires making a getNextDefaultThermocyclerModuleId similar to getNextDefaultTemperatureModuleId

(Note: there will be more prepopulated fields to update, see follow-up ticket #5577 )

Acceptance criteria

  • New form should be created with moduleId selected to match the existing thermocycler's ID
@IanLondon IanLondon added protocol designer Affects the `protocol-designer` project 🕷️ SPDDRS labels May 7, 2020
@umbhau umbhau mentioned this issue May 7, 2020
Closed
1 task
@Kadee80 Kadee80 self-assigned this May 7, 2020
Kadee80 added a commit that referenced this issue May 11, 2020
@Kadee80
feat(protocol-designer): Implement presaved step form for TC state
de61fdf 
closes #5596
@Kadee80 Kadee80 mentioned this issue May 11, 2020
Merged
1 task
@Kadee80 Kadee80 added this to the SPDDRS Sprint 8 milestone May 11, 2020
Kadee80 added a commit that referenced this issue May 11, 2020
@Kadee80
feat(protocol-designer): Implement presaved step form for TC state
ceee497 
closes #5596
Kadee80 added a commit that referenced this issue May 12, 2020
@Kadee80
feat(protocol-designer): Implement presaved step form for TC state (#…
32b191b 
…5641)

closes #5596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kadee80 Kadee80

Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
SPDDRS Sprint 8
Development

Successfully merging a pull request may close this issue.

feat(protocol-designer): Implement presaved step form for TC state Opentrons/opentrons
2 participants
@Kadee80 @IanLondon