Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: App doesn't report internal errors during labware calibration #5551

Closed
SyntaxColoring opened this issue May 3, 2020 · 4 comments
Closed
Labels
app Affects the `app` project bug hmg hardware, motion, and geometry rpc This involves Opentrons' deprecated RPC system.

Comments

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented May 3, 2020

Current behavior

As @mcous commented in #4810, during calibration...

The app collects the error from the API and does not display it.

Instead, it swallows the error silently. This makes things slightly more confusing for users. When something fails, it will look as if clicking the button in the app just didn't do anything. See #4810 for a concrete example.

Expected behavior

If something goes wrong during calibration, that should somehow be made clear to the user.

@SyntaxColoring SyntaxColoring added bug app Affects the `app` project rpc This involves Opentrons' deprecated RPC system. robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels May 3, 2020
@asogluizzo asogluizzo added the software-investigate Our Software team needs to look into this so we can understand more about it. label Nov 6, 2020
@asogluizzo
Copy link

Check back in on this after 4.0.0 release

@asogluizzo asogluizzo added the hmg hardware, motion, and geometry label Dec 4, 2020
@SyntaxColoring
Copy link
Contributor Author

According to @mcous, this is a problem with our RPC layer.

In v4.0.0, that RPC layer is no longer used for deck calibration or pipette offset calibration, so this should no longer be a problem for those.

It's still a problem for labware calibration. But labware calibration is going to be overhauled soon, including replacing its RPC layer.

@SyntaxColoring SyntaxColoring changed the title bug: App doesn't report internal errors during calibration bug: App doesn't report internal errors during labware calibration Mar 12, 2021
@mattwelch
Copy link

This ticket is now only relevant to labware calibration (as the other calibration stuff is handled by http versus rpc). This ticket is on the way too, as the labware cal project comes to completion.

Any lack of calibration errors using the new infrastructure should get their own tickets.

@mattwelch mattwelch removed the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Mar 12, 2021
@SyntaxColoring SyntaxColoring removed the software-investigate Our Software team needs to look into this so we can understand more about it. label Mar 12, 2021
@mcous
Copy link
Contributor

mcous commented Mar 4, 2022

Fixed in v5

@mcous mcous closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug hmg hardware, motion, and geometry rpc This involves Opentrons' deprecated RPC system.
Projects
None yet
Development

No branches or pull requests

4 participants