-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: App doesn't report internal errors during labware calibration #5551
Comments
Check back in on this after 4.0.0 release |
According to @mcous, this is a problem with our RPC layer. In v4.0.0, that RPC layer is no longer used for deck calibration or pipette offset calibration, so this should no longer be a problem for those. It's still a problem for labware calibration. But labware calibration is going to be overhauled soon, including replacing its RPC layer. |
This ticket is now only relevant to labware calibration (as the other calibration stuff is handled by http versus rpc). This ticket is on the way too, as the labware cal project comes to completion. Any lack of calibration errors using the new infrastructure should get their own tickets. |
Fixed in v5 |
Current behavior
As @mcous commented in #4810, during calibration...
Instead, it swallows the error silently. This makes things slightly more confusing for users. When something fails, it will look as if clicking the button in the app just didn't do anything. See #4810 for a concrete example.
Expected behavior
If something goes wrong during calibration, that should somehow be made clear to the user.
The text was updated successfully, but these errors were encountered: