Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labware calibration: "Continue moving to tip rack" button sometimes does nothing #4810

Closed
SyntaxColoring opened this issue Jan 21, 2020 · 3 comments
Labels
app Affects the `app` project bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). rpc This involves Opentrons' deprecated RPC system.
Milestone

Comments

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented Jan 21, 2020

Current behavior

The "Continue moving to tip rack" button in labware calibration sometimes silently fails.

  1. The user clicks the "Continue moving to tip rack" button during labware calibration.
  2. The loading spinner briefly appears over the tip on the deck layout view, then disappears.
  3. Nothing happens. The robot doesn't move. The user can't continue with labware calibration.

Expected behavior

Either the robot should move to the tip rack, or we should see an error message explaining why the robot isn't moving to the tip rack.

Possible causes

Opentrons employees, see this issue's Slack thread for case references.

Deck calibration

Redoing deck calibration has resolved the problem for one customer.

Internal AttributeError

This traceback comes from a customer's API log. This part seems to repeat every time the button is clicked.

[redacted] opentrons-api[339]: Moving p10_single_v1.3 to opentrons_96_tiprack_10ul in 6
[redacted] opentrons-api[339]: Exception during RPC call:
   Traceback (most recent call last):
    File "usr/lib/python3.7/site-packages/opentrons/server/rpc.py", line 270, in make_call
    File "usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    File "usr/lib/python3.7/site-packages/opentrons/server/rpc.py", line 260, in call_and_serialize
    File "usr/lib/python3.7/site-packages/opentrons/api/calibration.py", line 37, in decorated
    File "usr/lib/python3.7/site-packages/opentrons/api/calibration.py", line 53, in decorated
    File "usr/lib/python3.7/site-packages/opentrons/api/calibration.py", line 222, in move_to
    File "/buildroot/output/target/usr/lib/python3.7/contextlib.py", line 112, in __enter__
    File "usr/lib/python3.7/site-packages/opentrons/protocol_api/contexts.py", line 250, in temp_connect
  AttributeError: 'list' object has no attribute 'values'

If you're an Opentrons customer who's seeing this

Please send us your api.log and serial.log files so we can investigate. (Go to Advanced Settings > Download Logs and click Download.)

The logs will show information about how your OT-2 is being used. If you don't want that publicized, you can email them to [email protected] and mention this issue. Otherwise, you can upload them in this thread.

@SyntaxColoring SyntaxColoring added bug software-investigate Our Software team needs to look into this so we can understand more about it. labels Jan 21, 2020
@mcous mcous added app Affects the `app` project rpc This involves Opentrons' deprecated RPC system. and removed software-investigate Our Software team needs to look into this so we can understand more about it. labels Jan 21, 2020
@mcous
Copy link
Contributor

mcous commented Jan 21, 2020

The app collects the error from the API and does not display it. We can display the error, but as far as the error message goes, while calibration processes are on the legacy RPC API they will be mostly, if not completely, non-user-actionable.

The most common error to cause this behavior will be fixed by #4802

@mcous mcous added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Jan 21, 2020
@umbhau umbhau assigned umbhau, mcous and sanni-t and unassigned umbhau Feb 4, 2020
@umbhau umbhau added this to the CPX Sprint 2 milestone Feb 4, 2020
@mcous
Copy link
Contributor

mcous commented Feb 13, 2020

Oh also, unrelated to this fix for this ticket, but in the logs referenced above, that specific bug was fixed in #4614 and released in 3.15.2

@SyntaxColoring
Copy link
Contributor Author

Okay, so the issue here is that internal problems – whatever they might be – are silently swallowed instead of being displayed in an error dialog or whatever.

Rather than rewriting this ticket, I've created a new one: #5551. Closing this in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). rpc This involves Opentrons' deprecated RPC system.
Projects
None yet
Development

No branches or pull requests

4 participants