Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of custom labware on modules in PD #4910

Closed
7 tasks
IanLondon opened this issue Feb 3, 2020 · 0 comments · Fixed by #5175
Closed
7 tasks

Allow use of custom labware on modules in PD #4910

IanLondon opened this issue Feb 3, 2020 · 0 comments · Fixed by #5175
Assignees
Labels
protocol designer Affects the `protocol-designer` project

Comments

@IanLondon
Copy link
Contributor

IanLondon commented Feb 3, 2020

overview

This was skipped over and never implemented. All modules should support custom labware, even without the "disable module placement restrictions" setting enabled. Presently on edge, you get the orange "Incompatible labware" errors when attempting to put custom labware on to modules.

acceptance criteria

These are a little redundant to make sure all the cases are defined:

  • Any custom labware should be allowed to be added to any module via "+ Add to Slot"
  • Any custom labware should be allowed to be added to any module via drag-and-drop
  • Drag-and-drop should still NOT allow swapping an incompatible labware on to a module that has custom labware on it
  • All custom labware should be allowed to be added to the magnetic module (even with isMagneticModuleCompatible: false, even missing magneticModuleEngageHeight.
  • When using a custom labware that has a magneticModuleEngageHeight in the definition, that value should be used as the recommended value for the MAGNET form's engage height field.
  • When using a custom labware that does NOT have magneticModuleEngageHeight in the definition, don't give a recommended value: no caption should appear for the Engage Height field in this case.
  • When using a custom labware on the temperature module or thermocycler, you should be able to make temperature steps normally as if it's a standard labware.

additional step

In order to close this ticket, we must first ensure that the Python API won't error out if you try to place a custom labware on the magnetic module when the labware has isMagneticModuleCompatible: false and/or is missing magneticModuleEngageHeight (if that functionality requires more work to allow, break out into a new ticket and link to that ticket here)

@IanLondon IanLondon added protocol designer Affects the `protocol-designer` project 🕷️ SPDDRS labels Feb 3, 2020
@IanLondon IanLondon added this to the SPDDRS Sprint 4 milestone Feb 28, 2020
@jen-fong jen-fong self-assigned this Mar 4, 2020
jen-fong pushed a commit that referenced this issue Mar 12, 2020
* feat(protocol-designer): allow custom labware on modules on deck

closes #4910

* add tests

* clean up files and tests

* add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants