Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JSON v4 executor #4868

Closed
3 tasks
IanLondon opened this issue Jan 28, 2020 · 0 comments · Fixed by #5221
Closed
3 tasks

Make JSON v4 executor #4868

IanLondon opened this issue Jan 28, 2020 · 0 comments · Fixed by #5221
Assignees
@shlokamin
Labels
api Affects the `api` project blocked Ticket or PR is blocked by other work json protocol schema
Milestone
SPDDRS Sprint 4

Comments

@IanLondon
Copy link
Contributor

IanLondon commented Jan 28, 2020 •
edited by Kadee80
Loading

Add v4 executor that supports the new commands added in the new protocol schema set up in #4836

Testing Plan:

  • Test each command in the schema
  • Test Gen 1 modules
  • Test Gen 2 modules (hardcoded)
@IanLondon IanLondon added api Affects the `api` project json protocol schema labels Jan 28, 2020
@IanLondon IanLondon mentioned this issue Feb 5, 2020
Closed
@IanLondon IanLondon added the blocked Ticket or PR is blocked by other work label Feb 28, 2020
@shlokamin shlokamin added this to the SPDDRS Sprint 4 milestone Mar 9, 2020
shlokamin added a commit that referenced this issue Mar 12, 2020
@shlokamin
feat(api): add v4 JSON executor
d3c68ec 
#4868
@shlokamin shlokamin mentioned this issue Mar 12, 2020
Merged
shlokamin added a commit that referenced this issue Mar 16, 2020
@shlokamin
feat(api): add v4 JSON executor
2f36339 
#4868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlokamin shlokamin

Labels
api Affects the `api` project blocked Ticket or PR is blocked by other work json protocol schema
Projects
None yet
Milestone
SPDDRS Sprint 4
Development

Successfully merging a pull request may close this issue.

feat(api): add v4 JSON executor Opentrons/opentrons
2 participants
@shlokamin @IanLondon