-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make copyright status explicit in the opentrons repository / source code #4807
Comments
Thanks for the thoughts! We'll get that boilerplate added to the LICENSE file. Aside from that missing statement, though, I think we're pretty explicit in how everything is Apache-2.0 licensed:
So, if you're worried, please rest assured that everything in here is Apache 2.0 licensed! |
Thanks. commit d4250b6 solves this issue. |
@DerAndere1 I'm actually unable to find any documentation that states this sort of notice is required for the license to be valid. I'm of the personal opinion that it is optional, given:
Are you able to point me to any documentation that states that a NOTICE file (and/or the source code boilerplates, which we're not fans of) is strictly required? |
The appendix of your LICENSE file mentions no alternive method of licensing source code. But now I see that https://www.apache.org/licenses/LICENSE-2.0 has an alternatve apendix, so the copyright statement may be only required if you require attribution. In any case, that one line of plain-text copyright notice in the NOTICE file (or alternatively a copyright notice in each file) ensures attribution and documentation of copyright in derivative code, even if only a single file was copied into another codebase and modified. Remember that the source code in the public repository is a distribution itself (source form), seperate from any packaged release. I think, package.json only ensures that a plain-text copyright notice and LICENSE text is added to OTHER distributions (packaged releases) of this work. |
overview
It would make people more comfortable if you could make the copyright and license status of the opentrons source code explicit. Currently there is an Apache 2.0 license file at the root of the repository. However that license is not applied properly.
current behavior
Copyright notice and license info boilerplate missing.
steps to reproduce
use the Github search inside this repository to find instances of "Copyright".
->No explicit copyright notice is found, except some third-party statements and a generated one in api/docs/.../conf.py which pertains only to the documentation.
expected behavior
Copyright statement and license boilerplate, at least somewhere in this repository, in one or more prominent places. If you want to keep all copyright and license information in one place, add a preface text at the beginning of the license file that includes a notion to what parts of the repository the Apache 2.0 License applies, followed by the required boilerplate and copyright notice, followed by the Apache 2.0 License text itself. Or add the boilerplate in the beginning of some or most files.
Here is the relevant excerpt from the Apache 2.0 license appendix:
Copyright [yyyy] [name of copyright owner]
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
The text was updated successfully, but these errors were encountered: