Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Calibrate to bottom" diagram incorrect when calibrating reservoirs with multi-channel pipettes #4734

Closed
SyntaxColoring opened this issue Jan 14, 2020 · 1 comment
Closed

"Calibrate to bottom" diagram incorrect when calibrating reservoirs with multi-channel pipettes #4734

SyntaxColoring opened this issue Jan 14, 2020 · 1 comment
Labels
app Affects the `app` project bug hmg hardware, motion, and geometry

Comments

@SyntaxColoring
Copy link
Contributor

Overview

The calibration flow has an illustration to explain how to align the pipette tip to the top of a well.

If the calibrate to bottom switch is enabled, that image isn't updated. It will tell the user to calibrate to the top of the well even though they should calibrate to the bottom.

This report comes from a user, who was specifically testing with a 12-well reservoir.

Expected behavior

If the calibrate to bottom switch is enabled, it should change the image in the labware calibration flow accordingly.
@SyntaxColoring SyntaxColoring added app Affects the `app` project feature-request A request for a new feature or a change that isn't a bug. May require further triage or scoping. labels Jan 14, 2020
@SyntaxColoring SyntaxColoring changed the title "Calibrate to bottom" should be represented in instructional illustration "Calibrate to bottom" should change the instructional illustration accordingly Jan 14, 2020
@mcous mcous added bug and removed feature-request A request for a new feature or a change that isn't a bug. May require further triage or scoping. labels Jan 17, 2020
@mcous
Copy link
Contributor

mcous commented Jan 17, 2020

Regression introduced by #3823 and exposed by the switch to PAPIv2. The App tries to display calibrate to bottom diagrams for all labware, but the diagram is incorrect in the one case of calibrating a reservoir with a multi-channel pipette

@mcous mcous changed the title "Calibrate to bottom" should change the instructional illustration accordingly "Calibrate to bottom" diagram incorrect when calibrating reservoirs with multi-channel pipettes Jan 17, 2020
@mcous mcous added the hmg hardware, motion, and geometry label Jan 17, 2020
ahiuchingau added a commit that referenced this issue Jun 22, 2020
@ahiuchingau
fix(app): fix calibrate to trough bottom image for multi pipettes
61036a4 
closes #4734
@SyntaxColoring SyntaxColoring mentioned this issue Jul 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app Affects the `app` project bug hmg hardware, motion, and geometry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcous @SyntaxColoring