fix(app): clear lw calibration state if top level home is called #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #4703 +/- ##
==========================================
+ Coverage 58.07% 58.07% +<.01%
==========================================
Files 952 952
Lines 26233 26233
==========================================
+ Hits 15234 15235 +1
+ Misses 10999 10998 -1
Continue to review full report at Codecov.
|
mcous
reviewed
Jan 8, 2020
app/src/robot/reducer/calibration.js
Outdated
| @@ -84,6 +84,7 @@ export default function calibrationReducer( | |||
| return INITIAL_STATE | |||
|
|
|||
| // reset calibration state on robot home | |||
| case 'robotControls:HOME': | |||
There was a problem hiding this comment.
This constant is available as import { HOME } from '../../robot-controls'. Also, could you add tests for this behavior?
mcous
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This should fix a behavior where a user starts labware calibration and exits the flow to home the robot from the robots tab, which breaks their calibration experience when they return.