fix(app): naïve loading state for tc open lid during lw cal #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
previously requested changes
Dec 16, 2019
There was a problem hiding this comment.
- Can this happen after refactor(app): wire components to new state.modules tree #4615? They both touch this file and 4615 simplifies its props slightly
- We can't use
setTimeoutwithout cleaning up the timeout on dismount
Codecov Report
@@ Coverage Diff @@
## edge #4616 +/- ##
=========================================
+ Coverage 57.99% 58% +0.01%
=========================================
Files 933 934 +1
Lines 26010 26021 +11
=========================================
+ Hits 15084 15093 +9
- Misses 10926 10928 +2
Continue to review full report at Codecov.
|
mcous
reviewed
Dec 16, 2019
| @@ -3,7 +3,7 @@ import * as React from 'react' | |||
| import { mount } from 'enzyme' | |||
| import { useInterval } from '..' | |||
|
|
|||
| describe('usePrevious hook', () => { | |||
| describe('useInterval hook', () => { | |||
b-cooper
force-pushed
the
app_tc-is-opening
branch
from
6fbb842 to
48c9122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
In the absence of live status updates while the lid is opening or closing (limitation of the TC firmware), this adds a naïve loading state that delays a set amount of time in order to show to the user that the task has begun.
review requests
Enter Labware Calibration for a protocol that involves a TC, and make sure the lid of the thermocycler is closed. When prompted to "Open Lid" the loading state should appear (disabled button and spinner)