Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): show special-case warning for north/south #4361

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented Nov 1, 2019

overview

closes #4332

changelog

  • refactor DeckSetup
  • show "No 8-Channel GEN1 access" warning where appropriate
  • rename RobotWorkSpace's slot arg to deckSlotsById

review requests

Start with "disable module restriction" setting OFF.

  • If you have at least one GEN1 multichannel pipette in your protocol, show the on-deck warning in slot 4 if there's any module in slot 1, and in slot 6 if there's any module in slot 3
  • If you don't have any GEN1 multichannel pipettes in your protocol, this warning does not show on the deck
  • If the experimental setting "disable module restrictions" is on, don't ever show this warning
  • Refactor of RobotWorkSpace child props should not mess up anything deck-related in component library (compare to edge, because component library has some upside-down stuff that's been upside-down for a while 🤣 )
  • Refactor of RobotWorkSpace child props should not mess up anything in Run App

@IanLondon IanLondon added ready for review protocol designer Affects the `protocol-designer` project labels Nov 1, 2019
@IanLondon IanLondon requested a review from Kadee80 November 1, 2019 12:04
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #4361 into edge will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4361      +/-   ##
==========================================
- Coverage   56.05%   56.01%   -0.05%     
==========================================
  Files         896      897       +1     
  Lines       25125    25145      +20     
==========================================
  Hits        14085    14085              
- Misses      11040    11060      +20
Impacted Files Coverage Δ
components/src/deck/RobotWorkSpace.js 0% <0%> (ø) ⬆️
...l-designer/src/components/DeckSetup/SlotWarning.js 0% <0%> (ø)
...col-designer/src/components/DeckSetup/DeckSetup.js 0% <0%> (ø) ⬆️
app/src/components/DeckMap/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d8fea...115ccb5. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ 🏷

  • FF off, warnings show for Gen1 8 channel pipettes
  • FF off, warnings do not show for single channel pipettes
  • FF on, warnings do not show
  • Deckmap in PD looks sane
    Deckmap in App appears unaffected by refactor

@IanLondon IanLondon merged commit 86912e8 into edge Nov 4, 2019
@IanLondon IanLondon deleted the pd_north-south-on-deck-warning-4332 branch November 4, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD: Deck Setup - On-deck warning about 8-channel GEN1 access
2 participants