feat(app): allow p1000 gen2 to fallback to specced p1000 gen1 #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
reviewed
Oct 29, 2019
Codecov Report
@@ Coverage Diff @@
## release_3.14.0 #4316 +/- ##
===================================================
- Coverage 74.55% 56.27% -18.29%
===================================================
Files 120 890 +770
Lines 13763 24936 +11173
===================================================
+ Hits 10261 14032 +3771
- Misses 3502 10904 +7402
Continue to review full report at Codecov.
|
|
Holding until #4326 is merged |
b-cooper
added
DO NOT MERGE
When a robot has an attached P1000 Single GEN2, the and the uploaded protocol has a P1000 Single GEN1 attached, the app should accept the newer actual pipette as an inexact match. This mirrors the case of P300 GEN2 -> P300 GEN1 and P20 GEN2 -> P10 GEN1. re #3598
b-cooper
added
shared data
b-cooper
force-pushed
the
app_p1000-gen-fallback
branch
from
6fdbad8 to
3c7c2bc
Compare
mcous
approved these changes
Oct 30, 2019
| return false | ||
| } | ||
| function pipettesAreInexactMatch( | ||
| protocolInstrName, |
There was a problem hiding this comment.
Why is this parameter untyped? It looks like it needs to know to accept string and void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a robot has an attached P1000 Single GEN2, the and the uploaded protocol has a P1000 Single GEN1 specified, the app should accept the newer actual pipette as an inexact match. This mirrors the case of P300 GEN2 -> P300 GEN1 and P20 GEN2 -> P10 GEN1.
re #3598